[GitHub] [incubator-pinot] mcvsubbu commented on pull request #6291: Add consumption rate limiter for LLConsumer

[GitBox <gi...@apache.org>]

mcvsubbu commented on pull request #6291:
URL: https://github.com/apache/incubator-pinot/pull/6291#issuecomment-733963720


   Can you note in your checkin comments that what we are throttling is not really the consumption, but the _processing_ of messages. We will still consume as much as we can from the stream.
   
   If we were to limit consumption, then the behavior will be somewhat like:
   
   ```
   while (true) {
     consumeMsgsAsPerSomeAllowedRate()
     processAllMsgsConsumed()
     sleepAsIndicatedByRateLimiter()
   }
   ```
   
   Whereas by rate limiting the processing, we are doing the following:
   
   ```
   while (true) {
     consumeAllMsgsThatWeCan()
     foreach(msg) {
       processMsg()
       sleepAsDictatedByRateLimiter()
     }
   }
   ```
   
   So, we may be taking up more heap in the second case ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org