[GitHub] [spark] liupc commented on a change in pull request #23695: [SPARK-26780][CORE]Improve shuffle read using ReadAheadInputStream

[GitBox <gi...@apache.org>]

liupc commented on a change in pull request #23695: [SPARK-26780][CORE]Improve shuffle read using ReadAheadInputStream 
URL: https://github.com/apache/spark/pull/23695#discussion_r263984360
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
 ##########
 @@ -474,6 +475,12 @@ final class ShuffleBlockFetcherIterator(
               // TODO: manage the memory used here, and spill it into disk in case of OOM.
               Utils.copyStream(input, out, closeStreams = true)
               input = out.toChunkedByteBuffer.toInputStream(dispose = true)
+            } else {
+              val readAheadEnabled = SparkEnv.get != null &&
 
 Review comment:
   @10110346 
   Yes, I know it's got through `SparkEnv`, but we should put the call the same place to be consistent, or the code is messed up, and I the changes only involves a few of classes, and it's more natural. If you hold on your opinion, may be we should see other people's suggestion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org