[jira] [Comment Edited] (IGNITE-14913) Add cache statistics switch to control script

["Ilya Shishkov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-14913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454657#comment-17454657 ] 

Ilya Shishkov edited comment on IGNITE-14913 at 5/19/22 8:23 AM:
-----------------------------------------------------------------

It seems, that command with the proposed syntax (with regex) can result to the unpredictable results for an user.
I think, that 2 main use cases are to turn on/off or show status of metrics:
#  For all caches of a cluster.
#  For a particular list of the caches.

IMHO, below syntax is more suitable:
{code}
--cache metric enable|disable|status --caches cache1[,...,cacheN]|--all-caches
{code}


was (Author: shishkovilja):
It seems, that command with the proposed syntax (with regex) can result to the unpredictable results for an user.
I think, that 2 main use cases are to turn on/off or show status of metrics:
#  For all caches of a cluster.
#  For a particular list of the caches.

IMHO, below syntax is more suitable:
{code}
--cache metrics enable|disable|status --caches cache1[,...,cacheN]|--all-caches
{code}

> Add cache statistics switch to control script
> ---------------------------------------------
>
>                 Key: IGNITE-14913
>                 URL: https://issues.apache.org/jira/browse/IGNITE-14913
>             Project: Ignite
>          Issue Type: New Feature
>          Components: control.sh
>            Reporter: Ilya Shishkov
>            Assignee: Ilya Shishkov
>            Priority: Minor
>              Labels: ise
>             Fix For: 2.14
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Currently, enabling or disabling cache statistics is available only via IgniteVisorCmd or JMX. Because it seems that IgniteVisorCmd is no longer being developed, it would be helpful to add a cache statistics switch into the control script.
> Suggested syntax for a command:
> {code:java}
> --cache metrics enable|disable|status regexPattern
> {code}
> * regexPattern - regular expression for filtering caches (not cache groups) by their names. Caches with names satisfying the regular expression will be affected by the command. In case of an empty regex, the control script should finish execution with an error. If no matching caches are found, the control script should print a message about matching caches' absence.
> * enable - enables metrics for caches satisfying the 'regexPattern'.
> * disable - disables metrics for caches satisfying the 'regexPattern'.
> * status - prints current metrics status (enabled/disabled) for caches satisfying the 'regexPattern'.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)