You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by sraghunandan <gi...@git.apache.org> on 2018/02/08 16:01:42 UTC
[GitHub] carbondata pull request #1955: [HOTFIX] Fix documentation errors.
GitHub user sraghunandan opened a pull request:
https://github.com/apache/carbondata/pull/1955
[HOTFIX] Fix documentation errors.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
No
- [x] Any backward compatibility impacted?
No
- [x] Document update required?
Yes
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
NA
- [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sraghunandan/carbondata-1 make_doc_example_simple
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1955.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1955
----
commit 47e2396707c861774feb0a5f993038ad79ddc933
Author: Raghunandan S <ca...@...>
Date: 2018-02-08T16:00:03Z
[HOTFIX] Fix documentation errors.
----
---
[GitHub] carbondata issue #1955: [HOTFIX] Fix documentation errors.
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1955
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3447/
---
[GitHub] carbondata pull request #1955: [HOTFIX] Fix documentation errors.
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1955#discussion_r167416957
--- Diff: docs/data-management-on-carbondata.md ---
@@ -983,8 +975,8 @@ roll-up for the queries on these hierarchies.
USING "timeseries"
DMPROPERTIES (
'event_time’=’order_time’,
- 'day_granualrity’=’1’,
--- End diff --
Ｉ has fixed it in: https://github.com/apache/carbondata/pull/1949
。。。。
---
[GitHub] carbondata pull request #1955: [HOTFIX] Fix documentation errors.
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1955#discussion_r166984885
--- Diff: docs/data-management-on-carbondata.md ---
@@ -955,7 +947,7 @@ roll-up for the queries on these hierarchies.
USING "timeseries"
DMPROPERTIES (
'event_time’=’order_time’,
- 'year_granualrity’=’1’,
+ 'year_granularity’=’1’,
--- End diff --
please remove ","
---
[GitHub] carbondata issue #1955: [HOTFIX] Fix documentation errors.
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1955
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2411/
---
[GitHub] carbondata pull request #1955: [HOTFIX] Fix documentation errors.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1955
---
[GitHub] carbondata issue #1955: [HOTFIX] Fix documentation errors.
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1955
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3486/
---
[GitHub] carbondata issue #1955: [HOTFIX] Fix documentation errors.
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1955
LGTM
---
[GitHub] carbondata issue #1955: [HOTFIX] Fix documentation errors.
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1955
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3597/
---
[GitHub] carbondata issue #1955: [HOTFIX] Fix documentation errors.
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1955
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3446/
---
[GitHub] carbondata issue #1955: [HOTFIX] Fix documentation errors.
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1955
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3650/
---
[GitHub] carbondata issue #1955: [HOTFIX] Fix documentation errors.
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1955
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2359/
---