You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/03/01 11:07:32 UTC
[GitHub] [maven] cstamas opened a new pull request, #1021: [MNG-7713] Make Maven fail if option present
cstamas opened a new pull request, #1021:
URL: https://github.com/apache/maven/pull/1021
As with previous PR (simple removal) the `-llr` got interpreted as `-l lr`, it logged all output to `lr` file. This would maean that use of `-llr` would still sneakily 'work' and probably cause surprise down the road to users.
Returned the option, and expicitly checking for it's presence to be able to fail with meaningful message.
---
https://issues.apache.org/jira/browse/MNG-7713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas merged pull request #1021: [MNG-7713] Make Maven fail if option present
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #1021:
URL: https://github.com/apache/maven/pull/1021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on a diff in pull request #1021: [MNG-7713] Make Maven fail if option present
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #1021:
URL: https://github.com/apache/maven/pull/1021#discussion_r1121551376
##########
maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java:
##########
@@ -280,6 +280,12 @@ public CLIManager() {
.desc("Ineffective, only kept for backward compatibility")
.build());
+ // Adding this back to make Maven fail if used
Review Comment:
Please add info about conflict with `-l lr` - why we need it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on a diff in pull request #1021: [MNG-7713] Make Maven fail if option present
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #1021:
URL: https://github.com/apache/maven/pull/1021#discussion_r1121553055
##########
maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java:
##########
@@ -280,6 +280,12 @@ public CLIManager() {
.desc("Ineffective, only kept for backward compatibility")
.build());
+ // Adding this back to make Maven fail if used
Review Comment:
We need it not only to avoid conflicting `-l lr` but also to emit sane error message (so we really want to parse it from CLI but fail if present). So, I started a new "section" here (below the "ineffective section") for those that should fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org