You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "pengxiang-hao (via GitHub)" <gi...@apache.org> on 2023/08/25 13:54:51 UTC
[GitHub] [nuttx-apps] pengxiang-hao commented on a diff in pull request #1957: benchmarks/coremark: update SEED_METHOD/MEM_METHOD and debug
pengxiang-hao commented on code in PR #1957:
URL: https://github.com/apache/nuttx-apps/pull/1957#discussion_r1305693761
##########
benchmarks/coremark/Kconfig:
##########
@@ -27,6 +27,32 @@ config COREMARK_STACKSIZE
int "CoreMark task stack size"
default 4096
+config COREMARK_SEED_METHOD
+ int "Coremark Seed Method"
+ default 2
+ ---help---
+ Set Coremark Seed Method:
+ 0: SEED_ARG
+ 1: SEED_FUNC
+ 2: SEED_VOLATILE
+
+config COREMARK_MEM_METHOD
+ int "Coremark Memory Method"
+ default 1
+ ---help---
+ Set Coremark Memory Method:
+ 0: MEM_STATIC
+ 1: MEM_MALLOC
+ 2: MEM_STACK
Review Comment:
```
apps/benchmarks/coremark/Kconfig:50: error: couldn't parse 'default "GLOBAL" if (CONFIG_COREMARK_MEM_METHOD == 0)': expected symbol
```
it seems that `string` `default` with `equation` does not supported in nuttx Kconfig，only
```
default "heap" if COREMARK_MEM_METHOD
```
is accepted, should I just keep the original change
```
config COREMARK_MEM_LOCATION
string "Coremark memory location string"
default "Defined by the NuttX configuration"
```
or using another type, such like divide these into three Y/N condition which mapping value of `COREMARK_MEM_METHOD`?
---
```
config COREMARK_MEM_METHOD
int "Coremark Memory Method"
default 1
---help---
Set Coremark Memory Method:
0: MEM_STATIC
1: MEM_MALLOC
2: MEM_STACK
config COREMARK_MEM_USE_GLOBAL
bool "Use global memory for Coremark"
default y if COREMARK_MEM_METHOD == 0
---help---
Use global memory for Coremark
config COREMARK_MEM_USE_HEAP
bool "Use heap memory for Coremark"
default y if COREMARK_MEM_METHOD == 1
---help---
Use heap memory for Coremark
config COREMARK_MEM_USE_STACK
bool "Use stack memory for Coremark"
default y if COREMARK_MEM_METHOD == 2
---help---
Use stack memory for Coremark
config COREMARK_MEM_LOCATION
string "Coremark Memory Location"
default "Defined by the NuttX configuration" if COREMARK_MEM_USE_GLOBAL
default "heap" if COREMARK_MEM_USE_HEAP
default "stack" if COREMARK_MEM_USE_STACK
---help---
Set Coremark Memory Location:
0: global
1: heap
2: stack
```
##########
benchmarks/coremark/Kconfig:
##########
@@ -27,6 +27,32 @@ config COREMARK_STACKSIZE
int "CoreMark task stack size"
default 4096
+config COREMARK_SEED_METHOD
+ int "Coremark Seed Method"
+ default 2
+ ---help---
+ Set Coremark Seed Method:
+ 0: SEED_ARG
+ 1: SEED_FUNC
+ 2: SEED_VOLATILE
+
+config COREMARK_MEM_METHOD
+ int "Coremark Memory Method"
+ default 1
+ ---help---
+ Set Coremark Memory Method:
+ 0: MEM_STATIC
+ 1: MEM_MALLOC
+ 2: MEM_STACK
Review Comment:
```
apps/benchmarks/coremark/Kconfig:50: error: couldn't parse 'default "GLOBAL" if (CONFIG_COREMARK_MEM_METHOD == 0)': expected symbol
```
it seems that `string` `default` with `equation` does not supported in nuttx Kconfig，only
```
default "heap" if COREMARK_MEM_METHOD
```
is accepted, should I just keep the original change
```
config COREMARK_MEM_LOCATION
string "Coremark memory location string"
default "Defined by the NuttX configuration"
```
or using another type, such like divide these into three Y/N condition which mapping value of `COREMARK_MEM_METHOD`?
---
```
config COREMARK_MEM_METHOD
int "Coremark Memory Method"
default 1
---help---
Set Coremark Memory Method:
0: MEM_STATIC
1: MEM_MALLOC
2: MEM_STACK
config COREMARK_MEM_USE_GLOBAL
bool "Use global memory for Coremark"
default y if COREMARK_MEM_METHOD == 0
---help---
Use global memory for Coremark
config COREMARK_MEM_USE_HEAP
bool "Use heap memory for Coremark"
default y if COREMARK_MEM_METHOD == 1
---help---
Use heap memory for Coremark
config COREMARK_MEM_USE_STACK
bool "Use stack memory for Coremark"
default y if COREMARK_MEM_METHOD == 2
---help---
Use stack memory for Coremark
config COREMARK_MEM_LOCATION
string "Coremark Memory Location"
default "Defined by the NuttX configuration" if COREMARK_MEM_USE_GLOBAL
default "heap" if COREMARK_MEM_USE_HEAP
default "stack" if COREMARK_MEM_USE_STACK
---help---
Set Coremark Memory Location:
0: global
1: heap
2: stack
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org