[GitHub] [pinot] klsince commented on issue #9415: Minion Keeping segments on disk after RealtimeToOfflineSegmentsTask

[GitBox <gi...@apache.org>]

klsince commented on issue #9415:
URL: https://github.com/apache/pinot/issues/9415#issuecomment-1262928527

   some quick thoughts but need verify: although we do delete the files in a finally{} upon task completion, but we may not release all the mmap over those files, which is done by 
   ```
   // in SegmentProcessorFramework.process(): L145, under the hood, the record.offset/data files are mmap'ed 
   GenericRowFileReader fileReader = fileManager.getFileReader();
   ...
   // in SegmentProcessorFramework.process(): L166, but this is not called in finally block
   fileManager.cleanUp();
   ``` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org