You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Anurag Shekhar (JIRA)" <de...@db.apache.org> on 2006/03/28 12:13:23 UTC
[jira] Created: (DERBY-1155) Separate XAResource from
EmbedXAConnection
Separate XAResource from EmbedXAConnection
------------------------------------------
Key: DERBY-1155
URL: http://issues.apache.org/jira/browse/DERBY-1155
Project: Derby
Type: Improvement
Components: JDBC
Versions: 10.2.0.0
Environment: all
Reporter: Anurag Shekhar
Assigned to: Anurag Shekhar
jdbc4.0 introduces two new methods in javax.sql.PooledConnection. Due to this a new implementation of PooledConnection and XAConnection for jdbc4.0 is required. According to current hierarchy XAConnection extends from PooledConnection. Going by similar hierarchy for new classes PooledConnection40 will extend from PooledConnection and XAConnection40 will be extending from PooledConnection40.
This structure forces to replicate all the methods of XAConnection to be present in XAConnection40 too. In the current implementation EmbedXAConnection itself is XAResource. This will cause to replicate all the XAResource methods to be present in XAConnection40.
Separating these two implementation will save replication of lots of methods.
See the comments on jira issue 1137 for some more discussion about this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1155) Separate XAResource from
EmbedXAConnection
Posted by "Daniel John Debrunner (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1155?page=comments#action_12372135 ]
Daniel John Debrunner commented on DERBY-1155:
----------------------------------------------
Committed revision 389570.
> Separate XAResource from EmbedXAConnection
> ------------------------------------------
>
> Key: DERBY-1155
> URL: http://issues.apache.org/jira/browse/DERBY-1155
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Environment: all
> Reporter: Anurag Shekhar
> Assignee: Anurag Shekhar
> Attachments: derby-1155.diff
>
> jdbc4.0 introduces two new methods in javax.sql.PooledConnection. Due to this a new implementation of PooledConnection and XAConnection for jdbc4.0 is required. According to current hierarchy XAConnection extends from PooledConnection. Going by similar hierarchy for new classes PooledConnection40 will extend from PooledConnection and XAConnection40 will be extending from PooledConnection40.
> This structure forces to replicate all the methods of XAConnection to be present in XAConnection40 too. In the current implementation EmbedXAConnection itself is XAResource. This will cause to replicate all the XAResource methods to be present in XAConnection40.
> Separating these two implementation will save replication of lots of methods.
> See the comments on jira issue 1137 for some more discussion about this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1155) Separate XAResource from
EmbedXAConnection
Posted by "Daniel John Debrunner (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1155?page=comments#action_12372130 ]
Daniel John Debrunner commented on DERBY-1155:
----------------------------------------------
I'll commit this, with a couple of minor changes.
Fix the copyright for the new class to have the correct dates, all of its code is old code thus should retain the original copyright dates
Change EmbedXAResource to be non-public, don't think there is any reason for the class to be public.
> Separate XAResource from EmbedXAConnection
> ------------------------------------------
>
> Key: DERBY-1155
> URL: http://issues.apache.org/jira/browse/DERBY-1155
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Environment: all
> Reporter: Anurag Shekhar
> Assignee: Anurag Shekhar
> Attachments: derby-1155.diff
>
> jdbc4.0 introduces two new methods in javax.sql.PooledConnection. Due to this a new implementation of PooledConnection and XAConnection for jdbc4.0 is required. According to current hierarchy XAConnection extends from PooledConnection. Going by similar hierarchy for new classes PooledConnection40 will extend from PooledConnection and XAConnection40 will be extending from PooledConnection40.
> This structure forces to replicate all the methods of XAConnection to be present in XAConnection40 too. In the current implementation EmbedXAConnection itself is XAResource. This will cause to replicate all the XAResource methods to be present in XAConnection40.
> Separating these two implementation will save replication of lots of methods.
> See the comments on jira issue 1137 for some more discussion about this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1155) Separate XAResource from
EmbedXAConnection
Posted by "Anurag Shekhar (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1155?page=all ]
Anurag Shekhar updated DERBY-1155:
----------------------------------
Attachment: derby-1155.diff
Description of patch
Introduced new class EmbedXARessource. This class implements XAResources. I have moved all XAResource methods to this class.
Modified classes
EmbedXAConnection
Removed all the XAResource methods.
XATransactionState
This class now uses EmbedXAResource (earlier it was using EmbedXAConnection because it also had implementation of XAResource)
updated master files
checkDataSource30.out
checkDataSource.out
SecurityManager now checks additional class EmbedXAResource, which implements XAResource. Out files now have one extra line.
> Separate XAResource from EmbedXAConnection
> ------------------------------------------
>
> Key: DERBY-1155
> URL: http://issues.apache.org/jira/browse/DERBY-1155
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Environment: all
> Reporter: Anurag Shekhar
> Assignee: Anurag Shekhar
> Attachments: derby-1155.diff
>
> jdbc4.0 introduces two new methods in javax.sql.PooledConnection. Due to this a new implementation of PooledConnection and XAConnection for jdbc4.0 is required. According to current hierarchy XAConnection extends from PooledConnection. Going by similar hierarchy for new classes PooledConnection40 will extend from PooledConnection and XAConnection40 will be extending from PooledConnection40.
> This structure forces to replicate all the methods of XAConnection to be present in XAConnection40 too. In the current implementation EmbedXAConnection itself is XAResource. This will cause to replicate all the XAResource methods to be present in XAConnection40.
> Separating these two implementation will save replication of lots of methods.
> See the comments on jira issue 1137 for some more discussion about this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (DERBY-1155) Separate XAResource from
EmbedXAConnection
Posted by "Anurag Shekhar (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1155?page=all ]
Anurag Shekhar resolved DERBY-1155:
-----------------------------------
Fix Version: 10.2.0.0
Resolution: Fixed
> Separate XAResource from EmbedXAConnection
> ------------------------------------------
>
> Key: DERBY-1155
> URL: http://issues.apache.org/jira/browse/DERBY-1155
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Environment: all
> Reporter: Anurag Shekhar
> Assignee: Anurag Shekhar
> Fix For: 10.2.0.0
> Attachments: derby-1155.diff
>
> jdbc4.0 introduces two new methods in javax.sql.PooledConnection. Due to this a new implementation of PooledConnection and XAConnection for jdbc4.0 is required. According to current hierarchy XAConnection extends from PooledConnection. Going by similar hierarchy for new classes PooledConnection40 will extend from PooledConnection and XAConnection40 will be extending from PooledConnection40.
> This structure forces to replicate all the methods of XAConnection to be present in XAConnection40 too. In the current implementation EmbedXAConnection itself is XAResource. This will cause to replicate all the XAResource methods to be present in XAConnection40.
> Separating these two implementation will save replication of lots of methods.
> See the comments on jira issue 1137 for some more discussion about this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira