You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2015/08/25 20:21:03 UTC
Review Request 37768: GEODE-279: fix hang caused by unhandled
exception
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37768/
-----------------------------------------------------------
Review request for geode and Dan Smith.
Bugs: GEODE-279
https://issues.apache.org/jira/browse/GEODE-279
Repository: geode
Description
-------
GEODE-279: fix hang caused by unhandled exception
The old code thought catching CancelException would also catch RegionDestroyedException.
It is also possible to get other RuntimeExceptions in this code when it does a cancellation check.
So it now catches RuntimeException. Note that this may cause us to catch other, unexpected exceptions,
but in that case this code returns false and the message is then sent and will then get the same exception
and properly handle it.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java d557be6ca2050ee605eeb4eb6513b238e033ec45
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java 019740fddce30750e92501f3bd975456c147051c
Diff: https://reviews.apache.org/r/37768/diff/
Testing
-------
SerialGatewaySenderDistributedDeadlockDUnitTest
Thanks,
Darrel Schneider
Re: Review Request 37768: GEODE-279: fix hang caused by unhandled
exception
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37768/#review96395
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On Aug. 25, 2015, 6:21 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37768/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 6:21 p.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-279
> https://issues.apache.org/jira/browse/GEODE-279
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-279: fix hang caused by unhandled exception
>
> The old code thought catching CancelException would also catch RegionDestroyedException.
> It is also possible to get other RuntimeExceptions in this code when it does a cancellation check.
> So it now catches RuntimeException. Note that this may cause us to catch other, unexpected exceptions,
> but in that case this code returns false and the message is then sent and will then get the same exception
> and properly handle it.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java d557be6ca2050ee605eeb4eb6513b238e033ec45
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java 019740fddce30750e92501f3bd975456c147051c
>
> Diff: https://reviews.apache.org/r/37768/diff/
>
>
> Testing
> -------
>
> SerialGatewaySenderDistributedDeadlockDUnitTest
>
>
> Thanks,
>
> Darrel Schneider
>
>