You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Christian Ciach (JIRA)" <ji...@apache.org> on 2017/10/24 07:34:00 UTC

[jira] [Created] (THRIFT-4368) Guaranteed NPE in TBaseAsyncProcessor.java

Christian Ciach created THRIFT-4368:
---------------------------------------

             Summary: Guaranteed NPE in TBaseAsyncProcessor.java
                 Key: THRIFT-4368
                 URL: https://issues.apache.org/jira/browse/THRIFT-4368
             Project: Thrift
          Issue Type: Bug
          Components: Java - Library
    Affects Versions: 0.10.0
            Reporter: Christian Ciach


While creating a pull request for another ticket, the null-analyzer of Eclipse found a guaranteed NullPointerException in {{org.apache.thrift.TBaseAsyncProcessor<I>}}.

In the method {{process(AsyncFrameBuffer)}} we see this code fragment:
{{
        AsyncProcessFunction fn = processMap.get(msg.name);
        if (fn == null) {
            TProtocolUtil.skip(in, TType.STRUCT);
            in.readMessageEnd();
            if (!fn.isOneway()) {
}}

The variable {{fn}} can only be null in the last line.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)