You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2024/06/13 19:03:00 UTC
[jira] [Commented] (MRELEASE-1147) @junitVersion@ never replaced in UTs (make explicit)
[ https://issues.apache.org/jira/browse/MRELEASE-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854842#comment-17854842 ]
ASF GitHub Bot commented on MRELEASE-1147:
------------------------------------------
michael-o opened a new pull request, #220:
URL: https://github.com/apache/maven-release/pull/220
This closes #220
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MRELEASE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MRELEASE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MRELEASE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
> @junitVersion@ never replaced in UTs (make explicit)
> ----------------------------------------------------
>
> Key: MRELEASE-1147
> URL: https://issues.apache.org/jira/browse/MRELEASE-1147
> Project: Maven Release Plugin
> Issue Type: Bug
> Affects Versions: 3.0.1
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.1.0
>
>
> Maven Release Manager contains UTs which are supposed to resolve a {{@junitVersion@}}, but this something like this only happens in ITs. Before this starts to fail with newer Resolver versions we should make those placeholders explicit.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)