You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by de...@apache.org on 2011/01/06 21:07:48 UTC
svn commit: r1056049 - in
/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin:
changes/ChangesReportGenerator.java issues/IssuesReportGenerator.java
Author: dennisl
Date: Thu Jan 6 20:07:47 2011
New Revision: 1056049
URL: http://svn.apache.org/viewvc?rev=1056049&view=rev
Log:
Refactoring.
Modified:
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/ChangesReportGenerator.java
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/issues/IssuesReportGenerator.java
Modified: maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/ChangesReportGenerator.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/ChangesReportGenerator.java?rev=1056049&r1=1056048&r2=1056049&view=diff
==============================================================================
--- maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/ChangesReportGenerator.java (original)
+++ maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/ChangesReportGenerator.java Thu Jan 6 20:07:47 2011
@@ -414,6 +414,7 @@ public class ChangesReportGenerator
private void sinkBeginReport( Sink sink, ResourceBundle bundle )
{
sink.head();
+
String title = null;
if ( report.getTitle() != null )
{
@@ -472,7 +473,7 @@ public class ChangesReportGenerator
sink.close();
}
- private void sinkFigure( String image, Sink sink, String altText )
+ private void sinkFigure( Sink sink, String image, String altText )
{
sink.figure();
@@ -508,7 +509,9 @@ public class ChangesReportGenerator
private void sinkSectionTitle1Anchor( Sink sink, String text, String anchor )
{
sink.sectionTitle1();
+
sink.text( text );
+
sink.sectionTitle1_();
sink.anchor( HtmlTools.encodeId( anchor ) );
@@ -558,7 +561,7 @@ public class ChangesReportGenerator
sink.tableCell();
- sinkFigure( image, sink, altText );
+ sinkFigure( sink, image, altText );
sink.tableCell_();
}
Modified: maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/issues/IssuesReportGenerator.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/issues/IssuesReportGenerator.java?rev=1056049&r1=1056048&r2=1056049&view=diff
==============================================================================
--- maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/issues/IssuesReportGenerator.java (original)
+++ maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/issues/IssuesReportGenerator.java Thu Jan 6 20:07:47 2011
@@ -274,8 +274,10 @@ public class IssuesReportGenerator
{
sink.head();
+ String title = null;
+ title = bundle.getString( "report.changes.header" );
sink.title();
- sink.text( bundle.getString( "report.issues.header" ) );
+ sink.text( title );
sink.title_();
sink.head_();
@@ -284,7 +286,23 @@ public class IssuesReportGenerator
sink.section1();
- sinkSectionTitle1( sink, bundle.getString( "report.issues.header" ) );
+ sinkSectionTitle1( sink, title );
+ }
+
+ private void sinkCell( Sink sink, String text )
+ {
+ sink.tableCell();
+
+ if ( text != null )
+ {
+ sink.text( text );
+ }
+ else
+ {
+ sink.rawText( " " );
+ }
+
+ sink.tableCell_();
}
private void sinkEndReport( Sink sink )
@@ -316,22 +334,6 @@ public class IssuesReportGenerator
sink.tableHeaderCell_();
}
- private void sinkCell( Sink sink, String text )
- {
- sink.tableCell();
-
- if ( text != null )
- {
- sink.text( text );
- }
- else
- {
- sink.rawText( " " );
- }
-
- sink.tableCell_();
- }
-
private void sinkSectionTitle1( Sink sink, String text )
{
sink.sectionTitle1();