You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by kh...@apache.org on 2018/04/02 16:47:31 UTC

[maven-shade-plugin] branch MSHADE-278 updated (0e29bba -> 02a8c30)

This is an automated email from the ASF dual-hosted git repository.

khmarbaise pushed a change to branch MSHADE-278
in repository https://gitbox.apache.org/repos/asf/maven-shade-plugin.git.


 discard 0e29bba  [MSHADE-278] - Print out the jar responsible for exceptions  o like "Error creating shaded jar: invalid LOC header (bad signature)"
     new 02a8c30  [MSHADE-278] - Print out the jar responsible for exceptions  o like "Error creating shaded jar: invalid LOC header (bad signature)"    improvement by Gary Gregory

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (0e29bba)
            \
             N -- N -- N   refs/heads/MSHADE-278 (02a8c30)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:

-- 
To stop receiving notification emails like this one, please contact
khmarbaise@apache.org.

[maven-shade-plugin] 01/01: [MSHADE-278] - Print out the jar responsible for exceptions o like "Error creating shaded jar: invalid LOC header (bad signature)" improvement by Gary Gregory

Posted by kh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

khmarbaise pushed a commit to branch MSHADE-278
in repository https://gitbox.apache.org/repos/asf/maven-shade-plugin.git

commit 02a8c301c612cee9b99ad27b2e8d8d0c7ea4e7ed
Author: Karl Heinz Marbaise <kh...@apache.org>
AuthorDate: Mon Apr 2 18:23:39 2018 +0200

    [MSHADE-278] - Print out the jar responsible for exceptions
     o like "Error creating shaded jar: invalid LOC header (bad signature)"
       improvement by Gary Gregory
---
 .../java/org/apache/maven/plugins/shade/DefaultShader.java   | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java b/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
index ec1fb96..ee633f8 100644
--- a/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
+++ b/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java
@@ -187,8 +187,16 @@ public class DefaultShader
 
                     if ( !entry.isDirectory() && !isFiltered( jarFilters, name ) )
                     {
-                        shadeSingleJar( shadeRequest, resources, transformers, remapper, jos, duplicates, jar, jarFile,
-                                        entry, name );
+                        try
+                        {
+                            shadeSingleJar( shadeRequest, resources, transformers, remapper, jos, duplicates, jar,
+                                            jarFile, entry, name );
+                        }
+                        catch ( Exception e )
+                        {
+                            throw new IOException( String.format( "Problem shading JAR %s entry %s: %s", jar, name, e ),
+                                                   e );
+                        }
                     }
                 }
 

-- 
To stop receiving notification emails like this one, please contact
khmarbaise@apache.org.