You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by mr...@apache.org on 2013/03/27 15:23:07 UTC
svn commit: r1461600 - in /jackrabbit/oak/trunk/oak-jcr/src:
main/java/org/apache/jackrabbit/oak/jcr/NodeImpl.java
test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
Author: mreutegg
Date: Wed Mar 27 14:23:07 2013
New Revision: 1461600
URL: http://svn.apache.org/r1461600
Log:
OAK-722: Type conversion broken
Modified:
jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/NodeImpl.java
jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
Modified: jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/NodeImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/NodeImpl.java?rev=1461600&r1=1461599&r2=1461600&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/NodeImpl.java (original)
+++ jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/NodeImpl.java Wed Mar 27 14:23:07 2013
@@ -413,7 +413,7 @@ public class NodeImpl<T extends NodeDele
Binary binary = factory.createBinary(value);
try {
Value v = factory.createValue(binary);
- return internalSetProperty(name, v, true);
+ return internalSetProperty(name, v, false);
} finally {
binary.dispose();
}
@@ -427,7 +427,7 @@ public class NodeImpl<T extends NodeDele
throws RepositoryException {
if (value != null) {
Value v = getValueFactory().createValue(value);
- return internalSetProperty(name, v, true);
+ return internalSetProperty(name, v, false);
} else {
return internalRemoveProperty(name);
}
@@ -437,14 +437,14 @@ public class NodeImpl<T extends NodeDele
public Property setProperty(String name, boolean value)
throws RepositoryException {
Value v = getValueFactory().createValue(value);
- return internalSetProperty(name, v, true);
+ return internalSetProperty(name, v, false);
}
@Override @Nonnull
public Property setProperty(String name, double value)
throws RepositoryException {
Value v = getValueFactory().createValue(value);
- return internalSetProperty(name, v, true);
+ return internalSetProperty(name, v, false);
}
@Override @Nonnull
@@ -452,7 +452,7 @@ public class NodeImpl<T extends NodeDele
throws RepositoryException {
if (value != null) {
Value v = getValueFactory().createValue(value);
- return internalSetProperty(name, v, true);
+ return internalSetProperty(name, v, false);
} else {
return internalRemoveProperty(name);
}
@@ -462,7 +462,7 @@ public class NodeImpl<T extends NodeDele
public Property setProperty(String name, long value)
throws RepositoryException {
Value v = getValueFactory().createValue(value);
- return internalSetProperty(name, v, true);
+ return internalSetProperty(name, v, false);
}
@Override @Nonnull
@@ -470,7 +470,7 @@ public class NodeImpl<T extends NodeDele
throws RepositoryException {
if (value != null) {
Value v = getValueFactory().createValue(value);
- return internalSetProperty(name, v, true);
+ return internalSetProperty(name, v, false);
} else {
return internalRemoveProperty(name);
}
@@ -481,7 +481,7 @@ public class NodeImpl<T extends NodeDele
throws RepositoryException {
if (value != null) {
Value v = getValueFactory().createValue(value);
- return internalSetProperty(name, v, true);
+ return internalSetProperty(name, v, false);
} else {
return internalRemoveProperty(name);
}
Modified: jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java?rev=1461600&r1=1461599&r2=1461600&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java (original)
+++ jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java Wed Mar 27 14:23:07 2013
@@ -1132,7 +1132,6 @@ public class RepositoryTest extends Abst
}
@Test
- @Ignore
public void setPropertyWithConversion() throws RepositoryException {
Node n = getNode(TEST_PATH);
Node file = n.addNode("file", "nt:file");