You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/21 00:05:12 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #37593: [SPARK-40111][PYTHON][DOCS] Make pyspark.rdd examples self-contained
zhengruifeng opened a new pull request, #37593:
URL: https://github.com/apache/spark/pull/37593
### What changes were proposed in this pull request?
1, Make pyspark.rdd examples self-contained
2, add `versionadded` and `set-also`
### Why are the changes needed?
Make pyspark.rdd examples self-contained
### Does this PR introduce _any_ user-facing change?
yes, new docs
### How was this patch tested?
updated doctests and manual check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #37593: [SPARK-40111][PYTHON][DOCS] Make pyspark.rdd examples self-contained
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #37593: [SPARK-40111][PYTHON][DOCS] Make pyspark.rdd examples self-contained
URL: https://github.com/apache/spark/pull/37593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37593: [SPARK-40111][PYTHON][DOCS] Make pyspark.rdd examples self-contained
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37593:
URL: https://github.com/apache/spark/pull/37593#issuecomment-1221438483
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37593: [SPARK-40111][PYTHON][DOCS] Make pyspark.rdd examples self-contained
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #37593:
URL: https://github.com/apache/spark/pull/37593#discussion_r950765838
##########
python/pyspark/rdd.py:
##########
@@ -400,9 +501,41 @@ def unpersist(self: "RDD[T]", blocking: bool = False) -> "RDD[T]":
Mark the RDD as non-persistent, and remove all blocks for it from
memory and disk.
- .. versionchanged:: 3.0.0
- Added optional argument `blocking` to specify whether to block until all
- blocks are deleted.
+ .. versionadded:: 0.9.1
+
+ Parameters
+ ----------
+ blocking : bool, optional, default False
+ whether to block until all blocks are deleted
+
+ .. versionchanged:: 3.0.0
Review Comment:
```suggestion
.. versionadded:: 3.0.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37593: [SPARK-40111][PYTHON][DOCS] Make pyspark.rdd examples self-contained
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37593:
URL: https://github.com/apache/spark/pull/37593#issuecomment-1221436039
Wow, thank you @zhengruifeng for doing this!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org