You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/02/14 22:40:11 UTC
[GitHub] [hadoop] advancedwebdeveloper opened a new pull request #2700: HADOOP-17529. Upgrade os-maven-plugin to 1.7.0
advancedwebdeveloper opened a new pull request #2700:
URL: https://github.com/apache/hadoop/pull/2700
In favor of supporting RISC-V architecture.
CC @trustin
https://issues.apache.org/jira/browse/HADOOP-17529
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] advancedwebdeveloper commented on pull request #2700: HADOOP-17529. Upgrade os-maven-plugin to 1.7.0
Posted by GitBox <gi...@apache.org>.
advancedwebdeveloper commented on pull request #2700:
URL: https://github.com/apache/hadoop/pull/2700#issuecomment-780921454
I am hardly able to follow your thoughts.
I am not familiar with the module hierarchy - so please feel free to rewrite the source code yourself.
There is no specific JNI stuff, for os-maven-plugin, which would depend on your environment. Properly identified architecture allows to pick up the latest version of the artifact - but that should be enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #2700: HADOOP-17529. Upgrade os-maven-plugin to 1.7.0
Posted by GitBox <gi...@apache.org>.
steveloughran commented on pull request #2700:
URL: https://github.com/apache/hadoop/pull/2700#issuecomment-779751664
..we should also think about (purely for yetus runs) adding some spurious changes to those modules we want a native build to run for the regression tests. Akira -which ones are that these days?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on pull request #2700: HADOOP-17529. Upgrade os-maven-plugin to 1.7.0
Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #2700:
URL: https://github.com/apache/hadoop/pull/2700#issuecomment-778891054
Would you remove the following two lines to remove the duplicate properties and configurations?
https://github.com/apache/hadoop/blob/4331c88352da7f86b2fb6b629259e94730be5291/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/pom.xml#L31
https://github.com/apache/hadoop/blob/4331c88352da7f86b2fb6b629259e94730be5291/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi/pom.xml#L122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #2700: HADOOP-17529. Upgrade os-maven-plugin to 1.7.0
Posted by GitBox <gi...@apache.org>.
steveloughran commented on pull request #2700:
URL: https://github.com/apache/hadoop/pull/2700#issuecomment-781293684
> I am not familiar with the module hierarchy - so please feel free to rewrite the source code yourself.
well, the yarn-csi module depends on the main one, so it shouldn't be defining its own version. If the plugin version is set as a property in hadoop-project, then it can be referred to in both places
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2700: HADOOP-17529. Upgrade os-maven-plugin to 1.7.0
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2700:
URL: https://github.com/apache/hadoop/pull/2700#issuecomment-778863780
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 1m 11s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 34m 38s | | trunk passed |
| +1 :green_heart: | compile | 0m 16s | | trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 0m 16s | | trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | mvnsite | 0m 21s | | trunk passed |
| +1 :green_heart: | shadedclient | 51m 19s | | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 19s | | trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 17s | | trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 13s | | the patch passed |
| +1 :green_heart: | compile | 0m 11s | | the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 0m 11s | | the patch passed |
| +1 :green_heart: | compile | 0m 10s | | the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| +1 :green_heart: | javac | 0m 10s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 12s | | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedclient | 15m 16s | | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 15s | | the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 14s | | the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 13s | | hadoop-project in the patch passed. |
| +1 :green_heart: | asflicense | 0m 29s | | The patch does not generate ASF License warnings. |
| | | 72m 58s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2700/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2700 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml |
| uname | Linux 9d0d79277648 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / c3134ab3a99 |
| Default Java | Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2700/1/testReport/ |
| Max. process+thread count | 613 (vs. ulimit of 5500) |
| modules | C: hadoop-project U: hadoop-project |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2700/1/console |
| versions | git=2.25.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on pull request #2700: HADOOP-17529. Upgrade os-maven-plugin to 1.7.0
Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #2700:
URL: https://github.com/apache/hadoop/pull/2700#issuecomment-783219889
@advancedwebdeveloper
> So what should be done next?
You need to remove the two lines commented in https://github.com/apache/hadoop/pull/2700#issuecomment-778891054 to reflect the following comment:
> well, the yarn-csi module depends on the main one, so it shouldn't be defining its own version. If the plugin version is set as a property in hadoop-project, then it can be referred to in both places
I think it is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on pull request #2700: HADOOP-17529. Upgrade os-maven-plugin to 1.7.0
Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #2700:
URL: https://github.com/apache/hadoop/pull/2700#issuecomment-779754565
I think now os-maven-plugin is used only in the hadoop-yarn-csi module, so it is sufficient to add a change to a source java file in the module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] advancedwebdeveloper commented on pull request #2700: HADOOP-17529. Upgrade os-maven-plugin to 1.7.0
Posted by GitBox <gi...@apache.org>.
advancedwebdeveloper commented on pull request #2700:
URL: https://github.com/apache/hadoop/pull/2700#issuecomment-782752956
So what should be done next?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org