You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/01 16:14:26 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27908: [SPARK-31000] Add ability to set table description via Catalog.createTable()

HyukjinKwon commented on a change in pull request #27908:
URL: https://github.com/apache/spark/pull/27908#discussion_r448472063



##########
File path: python/pyspark/sql/catalog.py
##########
@@ -159,7 +159,8 @@ def createExternalTable(self, tableName, path=None, source=None, schema=None, **
         return self.createTable(tableName, path, source, schema, **options)
 
     @since(2.2)
-    def createTable(self, tableName, path=None, source=None, schema=None, **options):
+    def createTable(
+            self, tableName, path=None, source=None, schema=None, description=None, **options):

Review comment:
       @nchammas, just for doubly sure, you tested this in PySpark manually, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org