[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #388: [SUREFIRE-1266] Skip junit dependency check if module has no tests to run

[GitBox <gi...@apache.org>]

slawekjaranowski commented on a change in pull request #388:
URL: https://github.com/apache/maven-surefire/pull/388#discussion_r748754593



##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -944,6 +944,7 @@ public void execute()
                         return;
                 }
             }
+            verifyParameters( true );

Review comment:
       second call? in one methd.

##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -1101,7 +1102,7 @@ else if ( out.isDirectory() )
         }
     }
 
-    boolean verifyParameters()
+    boolean verifyParameters( boolean pluginActive )

Review comment:
       What does `pluginActive` means ... ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org