You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by do...@apache.org on 2021/08/06 20:37:34 UTC

[orc] 01/02: ORC-911: Remove janino dependency in favor of Spark's transitive dependency (#817)

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch branch-1.7
in repository https://gitbox.apache.org/repos/asf/orc.git

commit 426e83831d5549c14e332415b56c29d30c4f6dd0
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Thu Aug 5 21:24:51 2021 -0700

    ORC-911: Remove janino dependency in favor of Spark's transitive dependency (#817)
    
    ### What changes were proposed in this pull request?
    
    This PR aims to remove `janino` runtime dependency from `bench` module in favor of Spark's transitive dependency.
    
    ### Why are the changes needed?
    
    We should not override it. Spark uses a specific version because some latest Janino has bugs.
    
    ### How was this patch tested?
    
    Pass the CIs.
    
    Closes #799 and #804 .
    
    (cherry picked from commit 5c6008d1ad13b8dde39c427efd39eaff934ee773)
    Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
 java/bench/pom.xml       | 12 ------------
 java/bench/spark/pom.xml |  8 --------
 2 files changed, 20 deletions(-)

diff --git a/java/bench/pom.xml b/java/bench/pom.xml
index 8f5cfbe..c73cfef 100644
--- a/java/bench/pom.xml
+++ b/java/bench/pom.xml
@@ -409,18 +409,6 @@
         <version>${spark.version}</version>
       </dependency>
       <dependency>
-        <groupId>org.codehaus.janino</groupId>
-        <artifactId>janino</artifactId>
-        <version>3.0.8</version>
-        <scope>runtime</scope>
-      </dependency>
-      <dependency>
-        <groupId>org.codehaus.janino</groupId>
-        <artifactId>commons-compiler</artifactId>
-        <version>3.0.8</version>
-        <scope>runtime</scope>
-      </dependency>
-      <dependency>
         <groupId>org.jodd</groupId>
         <artifactId>jodd-core</artifactId>
         <version>3.5.2</version>
diff --git a/java/bench/spark/pom.xml b/java/bench/spark/pom.xml
index 721d8f2..8bed284 100644
--- a/java/bench/spark/pom.xml
+++ b/java/bench/spark/pom.xml
@@ -111,14 +111,6 @@
       <artifactId>spark-avro_2.12</artifactId>
     </dependency>
     <dependency>
-      <groupId>org.codehaus.janino</groupId>
-      <artifactId>janino</artifactId>
-    </dependency>
-    <dependency>
-      <groupId>org.codehaus.janino</groupId>
-      <artifactId>commons-compiler</artifactId>
-    </dependency>
-    <dependency>
       <groupId>org.jodd</groupId>
       <artifactId>jodd-core</artifactId>
     </dependency>