You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2019/12/11 08:27:19 UTC

[GitHub] [lucene-solr] dweiss commented on issue #1070: LUCENE-9089: FST Builder fluent-style constructor.

dweiss commented on issue #1070: LUCENE-9089: FST Builder fluent-style constructor.
URL: https://github.com/apache/lucene-solr/pull/1070#issuecomment-564432652
 
 
   This is a builder-on-builder now. :) We should have used a different name for the "compiler" of FSTs then it could become:
   
   FST
   FSTCompiler
   FSTCompiler.Builder
   
   and then:
   FSTCompiler.build() -> FSTCompiler.Builder.build() -> FSTCompiler().[add()*|build()] -> FST
   
   But it looks like a nice improvement even now!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org