You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by hustfxj <gi...@git.apache.org> on 2016/03/08 11:55:44 UTC
[GitHub] storm pull request: [STORM-1610] port pacemaker_state_factory_test...
GitHub user hustfxj opened a pull request:
https://github.com/apache/storm/pull/1192
[STORM-1610] port pacemaker_state_factory_test.clj to java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hustfxj/storm pacemaker-state-factory-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1192
----
commit c1a240cd6f76fa4ac4db2c26c28b4dd8fd1c3d24
Author: xiaojian.fxj <xi...@alibaba-inc.com>
Date: 2016-03-08T10:52:47Z
port pacemaker_state_factory_test.clj to java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1610] port pacemaker_state_factory_test...
Posted by satishd <gi...@git.apache.org>.
Github user satishd commented on the pull request:
https://github.com/apache/storm/pull/1192#issuecomment-193793125
@abhishekagarwal87 @hustfxj
I do not think @Before annotation can be used here as it needs to create storage for different HBServerMessageType instances in test methods.
You may want to extract methods like below and use it in respective test methods.
``` java
public PaceMakerStateStorage createPaceMakerStateStorage(HBServerMessageType messageType) {
return createPaceMakerStateStorage(createPaceMakerStateStorage, null);
}
public PaceMakerStateStorage createPaceMakerStateStorage(HBServerMessageType messageType, HBMessageData messageData) {
HBMessage response = new HBMessage(messageType, messageData);
PaceMakerClientProxy clientProxy = new PaceMakerClientProxy(response, null);
PaceMakerStateStorage stateStorage = new PaceMakerStateStorage(clientProxy, null);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1610] port pacemaker_state_factory_test...
Posted by zhuoliu <gi...@git.apache.org>.
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1192#issuecomment-194074562
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1610] port pacemaker_state_factory_test...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1192
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1610] port pacemaker_state_factory_test...
Posted by abhishekagarwal87 <gi...@git.apache.org>.
Github user abhishekagarwal87 commented on the pull request:
https://github.com/apache/storm/pull/1192#issuecomment-194185091
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1610] port pacemaker_state_factory_test...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1192#issuecomment-193915278
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1610] port pacemaker_state_factory_test...
Posted by hustfxj <gi...@git.apache.org>.
Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/1192#issuecomment-194179024
@zhuoliu @satishd @knusbaum @abhishekagarwal87 Thank you. I have addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1610] port pacemaker_state_factory_test...
Posted by abhishekagarwal87 <gi...@git.apache.org>.
Github user abhishekagarwal87 commented on the pull request:
https://github.com/apache/storm/pull/1192#issuecomment-193803584
@satishd I missed that. +1 to what you have suggested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1610] port pacemaker_state_factory_test...
Posted by satishd <gi...@git.apache.org>.
Github user satishd commented on the pull request:
https://github.com/apache/storm/pull/1192#issuecomment-194183788
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1610] port pacemaker_state_factory_test...
Posted by abhishekagarwal87 <gi...@git.apache.org>.
Github user abhishekagarwal87 commented on the pull request:
https://github.com/apache/storm/pull/1192#issuecomment-193779060
You can put
```
PaceMakerClientProxy clientProxy = new PaceMakerClientProxy(response, null);
PaceMakerStateStorage stateStorage = new PaceMakerStateStorage(clientProxy, null);
```
in a method annotated with @Before of Junit and declare stateStorage as global variable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1610] port pacemaker_state_factory_test...
Posted by zhuoliu <gi...@git.apache.org>.
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1192#issuecomment-194906318
still +1, sure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1610] port pacemaker_state_factory_test...
Posted by hustfxj <gi...@git.apache.org>.
Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/1192#issuecomment-194905475
@zhuoliu if it's ok, can you merge it ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---