You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/03/03 09:27:41 UTC
Review Request 57272: RANGER-1419:Do some code improvement in Java
method XTrxLogService.searchXTrxLogs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57272/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1419
https://issues.apache.org/jira/browse/RANGER-1419
Repository: ranger
Description
-------
#Solution:
Do some code improvement in Java method XTrxLogService.searchXTrxLogs and
some related code.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 20db24e
Diff: https://reviews.apache.org/r/57272/diff/1/
Testing
-------
#Test Result:
1.Start Ranger-Admin success
2.Search success in Audit Admin WebPage
Thanks,
Qiang Zhang
Re: Review Request 57272: RANGER-1419:Do some code improvement in Java
method XTrxLogService.searchXTrxLogs
Posted by Qiang Zhang <zh...@zte.com.cn>.
> On \u4e09\u6708 6, 2017, 10:31 a.m., Colm O hEigeartaigh wrote:
> > Line +207: SingularAttribute attr = entityType.getSingularAttribute(fieldName);
> >
> > This could be moved into the subsequent if statement, as it's only used in there.
OK, thanks.
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57272/#review167966
-----------------------------------------------------------
On \u4e09\u6708 7, 2017, 1:02 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57272/
> -----------------------------------------------------------
>
> (Updated \u4e09\u6708 7, 2017, 1:02 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1419
> https://issues.apache.org/jira/browse/RANGER-1419
>
>
> Repository: ranger
>
>
> Description
> -------
>
> #Solution:
> Do some code improvement in Java method XTrxLogService.searchXTrxLogs and
> some related code.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 20db24e
>
>
> Diff: https://reviews.apache.org/r/57272/diff/2/
>
>
> Testing
> -------
>
> #Test Result:
> 1.Start Ranger-Admin success
> 2.Search success in Audit Admin WebPage
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 57272: RANGER-1419:Do some code improvement in Java
method XTrxLogService.searchXTrxLogs
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57272/#review167966
-----------------------------------------------------------
Line +207: SingularAttribute attr = entityType.getSingularAttribute(fieldName);
This could be moved into the subsequent if statement, as it's only used in there.
- Colm O hEigeartaigh
On March 3, 2017, 9:27 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57272/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 9:27 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1419
> https://issues.apache.org/jira/browse/RANGER-1419
>
>
> Repository: ranger
>
>
> Description
> -------
>
> #Solution:
> Do some code improvement in Java method XTrxLogService.searchXTrxLogs and
> some related code.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 20db24e
>
>
> Diff: https://reviews.apache.org/r/57272/diff/1/
>
>
> Testing
> -------
>
> #Test Result:
> 1.Start Ranger-Admin success
> 2.Search success in Audit Admin WebPage
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 57272: RANGER-1419:Do some code improvement in Java
method XTrxLogService.searchXTrxLogs
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57272/#review168108
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On March 7, 2017, 1:02 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57272/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 1:02 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1419
> https://issues.apache.org/jira/browse/RANGER-1419
>
>
> Repository: ranger
>
>
> Description
> -------
>
> #Solution:
> Do some code improvement in Java method XTrxLogService.searchXTrxLogs and
> some related code.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 20db24e
>
>
> Diff: https://reviews.apache.org/r/57272/diff/2/
>
>
> Testing
> -------
>
> #Test Result:
> 1.Start Ranger-Admin success
> 2.Search success in Audit Admin WebPage
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 57272: RANGER-1419:Do some code improvement in Java
method XTrxLogService.searchXTrxLogs
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57272/
-----------------------------------------------------------
(Updated \u4e09\u6708 7, 2017, 1:02 a.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Move "SingularAttribute attr = entityType.getSingularAttribute(fieldName);" into the subsequent if statement.
Bugs: RANGER-1419
https://issues.apache.org/jira/browse/RANGER-1419
Repository: ranger
Description
-------
#Solution:
Do some code improvement in Java method XTrxLogService.searchXTrxLogs and
some related code.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 20db24e
Diff: https://reviews.apache.org/r/57272/diff/2/
Changes: https://reviews.apache.org/r/57272/diff/1-2/
Testing
-------
#Test Result:
1.Start Ranger-Admin success
2.Search success in Audit Admin WebPage
Thanks,
Qiang Zhang