You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by kennyballou <gi...@git.apache.org> on 2014/07/30 19:28:36 UTC
[GitHub] spark pull request: Docs: monitoring, streaming programming guide
GitHub user kennyballou opened a pull request:
https://github.com/apache/spark/pull/1662
Docs: monitoring, streaming programming guide
Fix several awkward wordings and grammatical issues in the following
documents:
* docs/monitoring.md
* docs/streaming-programming-guide.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennyballou/spark grammar_fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1662.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1662
----
commit e1b8ad62e034b1176ef420877d2048e806b409b8
Author: kballou <kb...@devnulllabs.io>
Date: 2014-07-30T17:24:04Z
Docs: monitoring, streaming programming guide
Fix several awkward wordings and grammatical issues in the following
documents:
* docs/monitoring.md
* docs/streaming-programming-guide.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Docs: monitoring, streaming programming guide
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/1662#issuecomment-50824844
I've merged this into `master` and `branch-1.0`. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Docs: monitoring, streaming programming guide
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/1662#issuecomment-50654258
@srowen We don't need a JIRA for patches that only fix small documentation typos, since we won't need a ticket to refer to in later discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Docs: monitoring, streaming programming guide
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/1662#issuecomment-50650807
Meta question: for trivial typo fixes, comment fixes, or non-functional code changes, is a JIRA needed? I'd personally say no.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Docs: monitoring, streaming programming guide
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1662#issuecomment-50650829
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Docs: monitoring, streaming programming guide
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1662
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---