You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/10/01 00:43:22 UTC
[GitHub] [iceberg] kbendick opened a new pull request #3209: Disable ErrorProne ConsistentLoggerName as we use alternative name
kbendick opened a new pull request #3209:
URL: https://github.com/apache/iceberg/pull/3209
When we recently upgraded the error prone library (I believe as of the Gradle upgrade), a new ErrorProne rule that's unique to the palantir repo has been added, `ConsistentLoggerName`.
As we typically use `LOG` for the logger name, but the warning wants it to be `log`, I have turned it off.
I only found about 5-6 instances where it wasn't called that.
While this is a nice goal, the palantir fork of error-prone doesn't seem to allow us to configure the expected name [as it's hard coded.](https://github.com/palantir/gradle-baseline/blob/779c6db14689b312bbdb2f4bc705cdfe2f61f078/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/ConsistentLoggerName.java#L64)
@nastra if you know of a way that we can change this to be `LOG`, that would be great.
Otherwise, I'm happy to update this to be `log` everywhere, but that will be a very large code change for not much benefit and adds a strain on people who maintain forks. Will leave this up to others to weigh in on as well.
Here's an example of the log:
```
/Users/kbendick/iceberg/api/src/main/java/org/apache/iceberg/io/CloseableGroup.java:42: warning: [ConsistentLoggerName] Loggers created using getLogger(Class<?>) must be named 'log'.
private static final Logger LOG = LoggerFactory.getLogger(CloseableGroup.class);
^
(see https://github.com/palantir/gradle-baseline#baseline-error-prone-checks)
Did you mean 'private static final Logger log = LoggerFactory.getLogger(CloseableGroup.class);'?
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #3209: Disable ErrorProne ConsistentLoggerName as we use alternative name
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #3209:
URL: https://github.com/apache/iceberg/pull/3209#issuecomment-931810319
In another branch I actually updated all of them automatically via `./gradlew clean compileJava -PerrorProneApply=ConsistentLoggerName` and the following amount of changes occurred:
73 files changed, 372 insertions(+), 372 deletions(-).
We can update them if we feel that 73 file changes and 372 line changes is worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #3209: Disable ErrorProne ConsistentLoggerName as we use alternative name
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #3209:
URL: https://github.com/apache/iceberg/pull/3209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3209: Disable ErrorProne ConsistentLoggerName as we use alternative name
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3209:
URL: https://github.com/apache/iceberg/pull/3209#issuecomment-932640316
Thanks, @kbendick!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org