You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by rg...@apache.org on 2019/12/10 15:31:11 UTC

[logging-log4j2] branch release-2.x updated: Fix unit tests

This is an automated email from the ASF dual-hosted git repository.

rgoers pushed a commit to branch release-2.x
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git


The following commit(s) were added to refs/heads/release-2.x by this push:
     new df175e3  Fix unit tests
df175e3 is described below

commit df175e39ff619413895dd508ce7eab6391a08946
Author: Ralph Goers <rg...@apache.org>
AuthorDate: Tue Dec 10 08:30:41 2019 -0700

    Fix unit tests
---
 .../resources/{log4j1-maprewrite.xml => log4j1-mapRewrite.xml}   | 0
 log4j-api/src/test/java/org/apache/logging/log4j/LoggerTest.java | 9 ++++++---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/log4j-1.2-api/src/test/resources/log4j1-maprewrite.xml b/log4j-1.2-api/src/test/resources/log4j1-mapRewrite.xml
similarity index 100%
rename from log4j-1.2-api/src/test/resources/log4j1-maprewrite.xml
rename to log4j-1.2-api/src/test/resources/log4j1-mapRewrite.xml
diff --git a/log4j-api/src/test/java/org/apache/logging/log4j/LoggerTest.java b/log4j-api/src/test/java/org/apache/logging/log4j/LoggerTest.java
index 54934b9..4a6af6c 100644
--- a/log4j-api/src/test/java/org/apache/logging/log4j/LoggerTest.java
+++ b/log4j-api/src/test/java/org/apache/logging/log4j/LoggerTest.java
@@ -64,10 +64,13 @@ public class LoggerTest {
         logger.atError().withMarker(marker).log("Hello {}", "John");
         logger.atWarn().withThrowable(new Throwable("This is a test")).log((Message) new SimpleMessage("Log4j rocks!"));
         assertEquals(3, results.size());
-        assertThat("Incorrect message 1", results.get(0), equalTo(" DEBUG org.apache.logging.log4j.LoggerTest.builder(LoggerTest.java:63) Hello"));
+        assertThat("Incorrect message 1", results.get(0),
+                equalTo(" DEBUG org.apache.logging.log4j.LoggerTest.builder(LoggerTest.java:63) Hello"));
         assertThat("Incorrect message 2", results.get(1), equalTo("test ERROR Hello John"));
-        assertThat("Incorrect message 3", results.get(2), startsWith(" WARN Log4j rocks! java.lang.Throwable: This is a test\n" +
-            "\tat org.apache.logging.log4j.LoggerTest.builder(LoggerTest.java:65)"));
+        assertThat("Incorrect message 3", results.get(2),
+                startsWith(" WARN Log4j rocks! java.lang.Throwable: This is a test"));
+        assertThat("Throwable incorrect in message 3", results.get(2),
+                containsString("at org.apache.logging.log4j.LoggerTest.builder(LoggerTest.java:65)"));
     }
 
     @Test