You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wanqulou <gi...@git.apache.org> on 2018/09/19 06:43:45 UTC
[GitHub] spark pull request #22463: remove annotation @Experimental
GitHub user wanqulou opened a pull request:
https://github.com/apache/spark/pull/22463
remove annotation @Experimental
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wanqulou/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22463.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22463
----
commit c034767abe196dad5acbddd4e2a1b437429813d3
Author: 孙翔 <wa...@...>
Date: 2018-09-19T06:39:17Z
Update KafkaUtils.scala
remove annotation @Experimental
commit 11866c4627168bc270f03f398939ba1d3e2ed512
Author: 孙翔 <wa...@...>
Date: 2018-09-19T06:42:01Z
remove annotation @Experimental
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22463: remove annotation @Experimental
Posted by markhamstra <gi...@git.apache.org>.
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/22463
Where is the discussion on these utility methods no longer being Experimental? I'm not saying that they are not stable, but the Kafka 0.10 API in general being considered to be stable doesn't preclude some Kafka-related methods from still being other than stable, and promoting API to stable (i.e. cannot be changed without a major release) is a pretty big deal.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22463: remove annotation @Experimental
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22463
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22463: remove annotation @Experimental
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22463
Why don't we just leave it or mark them as deprecated.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22463: remove annotation @Experimental
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22463
Yeah, I think Experimental is over-used in the APIs. They just never get un-marked and lots of pretty old stuff, that de facto is just not changeable now, is still labeled this way. This seems to be more "DeveloperAPI" than "Experimental". Still, I also don't know the right answer for this code. Ping the author?
I figured we'd remove just about all current Experimental tags when, say, Spark 3 rolls around.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22463: remove annotation @Experimental
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22463
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22463: remove annotation @Experimental
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22463
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22463: remove annotation @Experimental
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22463
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22463: remove annotation @Experimental
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22463
I'd close this, evaluate which Experimental tags look clearly 'wrong' (i.e. something long established in a public API) and then open a JIRA targeted at 3.0 to consider removing them.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org