[GitHub] jerrypeng commented on a change in pull request #1751: Allow ability to specify resources to functions

[GitBox <gi...@apache.org>]

jerrypeng commented on a change in pull request #1751: Allow ability to specify resources to functions
URL: https://github.com/apache/incubator-pulsar/pull/1751#discussion_r186931288
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java
 ##########
 @@ -133,6 +134,12 @@ void runCmd() throws Exception {
         @Parameter(names = "--sourceConfigFile", description = "The path to a YAML config file specifying the "
                 + "source's configuration")
         protected String sourceConfigFile;
+        @Parameter(names = "--cpu", description = "The cpu that need to be allocated per function instance(applicable only to docker runtime)")
 
 Review comment:
   probably want to specify the units for each of the resources in the description for clarity

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services