You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/12/21 02:12:25 UTC

[GitHub] [skywalking] zhyyu commented on pull request #10187: fix ServiceMeshServiceDispatcher overwrite ServiceDispatcher debug file when open SW_OAL_ENGINE_DEBUG.

zhyyu commented on PR #10187:
URL: https://github.com/apache/skywalking/pull/10187#issuecomment-1360695522

   > As this file is generated sequentially, you could generate `_index` when the name is in conflict. In your case, maybe `ServiceDispatcher.class` and `ServiceDispatcher_1.class` are a better choice. After all, this is not a runtime name.
   
   In my case, in the file content, the class name is `ServiceMeshServiceDispatcher`, but the file name is `ServiceDispatcher.class`. I have used `metricsClass.getSimpleName() `to replace the original argument `className` to fix the problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org