You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/03/21 05:06:33 UTC

[GitHub] [incubator-doris] xxiao2018 opened a new pull request #5543: [Bug] Fix multi broker load bug

xxiao2018 opened a new pull request #5543:
URL: https://github.com/apache/incubator-doris/pull/5543


   ## Proposed changes
   
   The storage type of broker desc should be set due to the type of load job
   
   ## Types of changes
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   
   ## Checklist
   
   - [x] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #5543: [Bug] Fix multi broker load bug

Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #5543:
URL: https://github.com/apache/incubator-doris/pull/5543#discussion_r598242095



##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/BrokerDesc.java
##########
@@ -60,7 +60,11 @@ public BrokerDesc(String name, Map<String, String> properties) {
         if (this.properties == null) {
             this.properties = Maps.newHashMap();
         }
-        this.storageType = StorageBackend.StorageType.BROKER;
+        if (this.name.equalsIgnoreCase(BrokerDesc.MULTI_LOAD_BROKER)) {

Review comment:
       ```suggestion
           if (isMultiLoadBroker()) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman merged pull request #5543: [Bug] Fix multi broker load bug

Posted by GitBox <gi...@apache.org>.
morningman merged pull request #5543:
URL: https://github.com/apache/incubator-doris/pull/5543


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #5543: [Bug] Fix multi broker load bug

Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #5543:
URL: https://github.com/apache/incubator-doris/pull/5543#discussion_r598242095



##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/BrokerDesc.java
##########
@@ -60,7 +60,11 @@ public BrokerDesc(String name, Map<String, String> properties) {
         if (this.properties == null) {
             this.properties = Maps.newHashMap();
         }
-        this.storageType = StorageBackend.StorageType.BROKER;
+        if (this.name.equalsIgnoreCase(BrokerDesc.MULTI_LOAD_BROKER)) {

Review comment:
       ```suggestion
           if (this.name.equalsIgnoreCase(BrokerDesc.MULTI_LOAD_BROKER)) {
           if (isMultiLoadBroker()) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org