You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Stas Bekman <st...@stason.org> on 2004/12/07 20:55:17 UTC

[mp2] getting rid of special cases for t/preconnection, protocol, filter, hooks

I'm not sure why this was done in first place, but in the test suite we 
now have:

t/protocol/TestProtocol
t/preconnection/TestPreConnection
t/hooks/TestHooks
t/filter/TestFilter

that polute the already huge @INC. I suggest to move those to t/response 
and get rid of the special cases. With svn it should be easy w/o losing 
the history.

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] getting rid of special cases for t/preconnection, protocol, filter, hooks

Posted by Stas Bekman <st...@stason.org>.
Philippe M. Chiasson wrote:
> Stas Bekman wrote:
> 
>> I'm not sure why this was done in first place, but in the test suite 
>> we now have:
>>
>> t/protocol/TestProtocol
>> t/preconnection/TestPreConnection
>> t/hooks/TestHooks
>> t/filter/TestFilter
>>
>> that polute the already huge @INC. I suggest to move those to 
>> t/response and get rid of the special cases. With svn it should be 
>> easy w/o losing the history.
> 
> 
> Go for it if you have time. +1 on concept

Hmm, something bizarre is going on:

% svn mv t/protocol/TestProtocol t/response
A         t/response/TestProtocol
D         t/protocol/TestProtocol/echo_bbs.pm
D         t/protocol/TestProtocol/eliza.pm
D         t/protocol/TestProtocol/echo_timeout.pm
D         t/protocol/TestProtocol/echo_bbs2.pm
D         t/protocol/TestProtocol/echo_block.pm
D         t/protocol/TestProtocol/pseudo_http.pm
D         t/protocol/TestProtocol/echo_filter.pm
D         t/protocol/TestProtocol/echo_nonblock.pm
D         t/protocol/TestProtocol

it deleted the files, moved the directory, but not re-added the files? Is 
that a bug in subversion or am I doing something wrong?

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] getting rid of special cases for t/preconnection, protocol, filter, hooks

Posted by "Philippe M. Chiasson" <go...@ectoplasm.org>.
Stas Bekman wrote:
> I'm not sure why this was done in first place, but in the test suite we 
> now have:
> 
> t/protocol/TestProtocol
> t/preconnection/TestPreConnection
> t/hooks/TestHooks
> t/filter/TestFilter
> 
> that polute the already huge @INC. I suggest to move those to t/response 
> and get rid of the special cases. With svn it should be easy w/o losing 
> the history.

Go for it if you have time. +1 on concept

--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5