You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Chris Dolan (Created) (JIRA)" <ji...@apache.org> on 2012/02/11 19:32:59 UTC
[jira] [Created] (KARAF-1199) dev:watch command issues "[WATCH]"
announcements only to the issuing shell
dev:watch command issues "[WATCH]" announcements only to the issuing shell
--------------------------------------------------------------------------
Key: KARAF-1199
URL: https://issues.apache.org/jira/browse/KARAF-1199
Project: Karaf
Issue Type: Bug
Components: karaf-shell
Affects Versions: 2.2.4
Reporter: Chris Dolan
Priority: Trivial
If I issue a "dev:watch *" command and later update one of my snapshot bundles, the announcement of that change is emitted in the context of the shell that issued the command. That is, if I issue it in the Gogo ssh shell, then the "[WATCH] ..." announcement goes to that shell. If I trigger the Watch service programmatically, then the announcement goes to the system console.
Instead, I think the announcement should go to the log subsystem. The root cause is that org.apache.karaf.shell.dev.BundleWatcher uses System.out.println() to emit this message, which is routed by Gogo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1199) dev:watch command issues "[WATCH]"
announcements only to the issuing shell
Posted by "Chris Dolan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209388#comment-13209388 ]
Chris Dolan commented on KARAF-1199:
------------------------------------
Guillaume, I think dev:watch is different from osgi:list because dev:watch has a persistent asynchronous component (the BundleWatcher) whereas osgi:list is purely synchronous. I'm proposing only that the background thread BundleWatcher message is emitted as a log message, not the synchronous output of dev:watch.
I'd be happy if the BundleWatcher message were emitted to both logging and console. But, yes, this is not for production which is why I marked it "trivial".
> dev:watch command issues "[WATCH]" announcements only to the issuing shell
> --------------------------------------------------------------------------
>
> Key: KARAF-1199
> URL: https://issues.apache.org/jira/browse/KARAF-1199
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.4
> Reporter: Chris Dolan
> Assignee: Jean-Baptiste Onofré
> Priority: Trivial
> Fix For: 2.2.6, 3.0.0
>
>
> If I issue a "dev:watch *" command and later update one of my snapshot bundles, the announcement of that change is emitted in the context of the shell that issued the command. That is, if I issue it in the Gogo ssh shell, then the "[WATCH] ..." announcement goes to that shell. If I trigger the Watch service programmatically, then the announcement goes to the system console.
> Instead, I think the announcement should go to the log subsystem. The root cause is that org.apache.karaf.shell.dev.BundleWatcher uses System.out.println() to emit this message, which is routed by Gogo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1199) dev:watch command issues "[WATCH]"
announcements only to the issuing shell
Posted by "Jean-Baptiste Onofré (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206353#comment-13206353 ]
Jean-Baptiste Onofré commented on KARAF-1199:
---------------------------------------------
It makes sense.
Generally speaking, all commands should use a logger for the log, and JLine Ansi for console output.
In the case of the BundleWatcher, it should use only log, and the watch command should relay it in the console.
> dev:watch command issues "[WATCH]" announcements only to the issuing shell
> --------------------------------------------------------------------------
>
> Key: KARAF-1199
> URL: https://issues.apache.org/jira/browse/KARAF-1199
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.4
> Reporter: Chris Dolan
> Priority: Trivial
> Fix For: 2.2.6, 3.0.0
>
>
> If I issue a "dev:watch *" command and later update one of my snapshot bundles, the announcement of that change is emitted in the context of the shell that issued the command. That is, if I issue it in the Gogo ssh shell, then the "[WATCH] ..." announcement goes to that shell. If I trigger the Watch service programmatically, then the announcement goes to the system console.
> Instead, I think the announcement should go to the log subsystem. The root cause is that org.apache.karaf.shell.dev.BundleWatcher uses System.out.println() to emit this message, which is routed by Gogo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1199) dev:watch command issues "[WATCH]"
announcements only to the issuing shell
Posted by "Jean-Baptiste Onofré (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré updated KARAF-1199:
----------------------------------------
Fix Version/s: 3.0.0
2.2.6
Assignee: Jean-Baptiste Onofré
> dev:watch command issues "[WATCH]" announcements only to the issuing shell
> --------------------------------------------------------------------------
>
> Key: KARAF-1199
> URL: https://issues.apache.org/jira/browse/KARAF-1199
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.4
> Reporter: Chris Dolan
> Assignee: Jean-Baptiste Onofré
> Priority: Trivial
> Fix For: 2.2.6, 3.0.0
>
>
> If I issue a "dev:watch *" command and later update one of my snapshot bundles, the announcement of that change is emitted in the context of the shell that issued the command. That is, if I issue it in the Gogo ssh shell, then the "[WATCH] ..." announcement goes to that shell. If I trigger the Watch service programmatically, then the announcement goes to the system console.
> Instead, I think the announcement should go to the log subsystem. The root cause is that org.apache.karaf.shell.dev.BundleWatcher uses System.out.println() to emit this message, which is routed by Gogo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1199) dev:watch command issues "[WATCH]"
announcements only to the issuing shell
Posted by "Guillaume Nodet (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209234#comment-13209234 ]
Guillaume Nodet commented on KARAF-1199:
----------------------------------------
Well, I somewhat disagree with that.
The original idea of the dev:watch command was to be a developer tool, not something to use in production.
Likewise, the osgi:list command does not output to the log system instead of the console.
I guess this should be configurable when launching the command, but I'd like to keep the current behavior which is a really nice tool when developing. Though even if the command output to the console, it'd be nice to have it log the changes anyway.
> dev:watch command issues "[WATCH]" announcements only to the issuing shell
> --------------------------------------------------------------------------
>
> Key: KARAF-1199
> URL: https://issues.apache.org/jira/browse/KARAF-1199
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.4
> Reporter: Chris Dolan
> Assignee: Jean-Baptiste Onofré
> Priority: Trivial
> Fix For: 2.2.6, 3.0.0
>
>
> If I issue a "dev:watch *" command and later update one of my snapshot bundles, the announcement of that change is emitted in the context of the shell that issued the command. That is, if I issue it in the Gogo ssh shell, then the "[WATCH] ..." announcement goes to that shell. If I trigger the Watch service programmatically, then the announcement goes to the system console.
> Instead, I think the announcement should go to the log subsystem. The root cause is that org.apache.karaf.shell.dev.BundleWatcher uses System.out.println() to emit this message, which is routed by Gogo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1199) dev:watch command issues "[WATCH]"
announcements only to the issuing shell
Posted by "Jean-Baptiste Onofré (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré updated KARAF-1199:
----------------------------------------
Fix Version/s: (was: 3.1.0)
3.0.0
> dev:watch command issues "[WATCH]" announcements only to the issuing shell
> --------------------------------------------------------------------------
>
> Key: KARAF-1199
> URL: https://issues.apache.org/jira/browse/KARAF-1199
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.4
> Reporter: Chris Dolan
> Assignee: Jean-Baptiste Onofré
> Priority: Trivial
> Fix For: 2.2.6, 3.0.0
>
>
> If I issue a "dev:watch *" command and later update one of my snapshot bundles, the announcement of that change is emitted in the context of the shell that issued the command. That is, if I issue it in the Gogo ssh shell, then the "[WATCH] ..." announcement goes to that shell. If I trigger the Watch service programmatically, then the announcement goes to the system console.
> Instead, I think the announcement should go to the log subsystem. The root cause is that org.apache.karaf.shell.dev.BundleWatcher uses System.out.println() to emit this message, which is routed by Gogo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (KARAF-1199) dev:watch command issues "[WATCH]"
announcements only to the issuing shell
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jamie goodyear closed KARAF-1199.
---------------------------------
> dev:watch command issues "[WATCH]" announcements only to the issuing shell
> --------------------------------------------------------------------------
>
> Key: KARAF-1199
> URL: https://issues.apache.org/jira/browse/KARAF-1199
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.4
> Reporter: Chris Dolan
> Assignee: Jean-Baptiste Onofré
> Priority: Trivial
> Fix For: 2.2.6, 3.0.0
>
>
> If I issue a "dev:watch *" command and later update one of my snapshot bundles, the announcement of that change is emitted in the context of the shell that issued the command. That is, if I issue it in the Gogo ssh shell, then the "[WATCH] ..." announcement goes to that shell. If I trigger the Watch service programmatically, then the announcement goes to the system console.
> Instead, I think the announcement should go to the log subsystem. The root cause is that org.apache.karaf.shell.dev.BundleWatcher uses System.out.println() to emit this message, which is routed by Gogo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KARAF-1199) dev:watch command issues "[WATCH]"
announcements only to the issuing shell
Posted by "Jean-Baptiste Onofré (Resolved JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré resolved KARAF-1199.
-----------------------------------------
Resolution: Fixed
> dev:watch command issues "[WATCH]" announcements only to the issuing shell
> --------------------------------------------------------------------------
>
> Key: KARAF-1199
> URL: https://issues.apache.org/jira/browse/KARAF-1199
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.4
> Reporter: Chris Dolan
> Assignee: Jean-Baptiste Onofré
> Priority: Trivial
> Fix For: 2.2.6, 3.0.0
>
>
> If I issue a "dev:watch *" command and later update one of my snapshot bundles, the announcement of that change is emitted in the context of the shell that issued the command. That is, if I issue it in the Gogo ssh shell, then the "[WATCH] ..." announcement goes to that shell. If I trigger the Watch service programmatically, then the announcement goes to the system console.
> Instead, I think the announcement should go to the log subsystem. The root cause is that org.apache.karaf.shell.dev.BundleWatcher uses System.out.println() to emit this message, which is routed by Gogo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1199) dev:watch command issues "[WATCH]"
announcements only to the issuing shell
Posted by "Jean-Baptiste Onofré (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209394#comment-13209394 ]
Jean-Baptiste Onofré commented on KARAF-1199:
---------------------------------------------
I'm agree with both you.
My proposal was to do both: let the default behavior as it is (log on the console), but also add message in the log file.
If the users don't want the log messages, they can "filter" the org.apache.karaf.dev logger in the org.ops4j.pax.logging.cfg file.
> dev:watch command issues "[WATCH]" announcements only to the issuing shell
> --------------------------------------------------------------------------
>
> Key: KARAF-1199
> URL: https://issues.apache.org/jira/browse/KARAF-1199
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.4
> Reporter: Chris Dolan
> Assignee: Jean-Baptiste Onofré
> Priority: Trivial
> Fix For: 2.2.6, 3.0.0
>
>
> If I issue a "dev:watch *" command and later update one of my snapshot bundles, the announcement of that change is emitted in the context of the shell that issued the command. That is, if I issue it in the Gogo ssh shell, then the "[WATCH] ..." announcement goes to that shell. If I trigger the Watch service programmatically, then the announcement goes to the system console.
> Instead, I think the announcement should go to the log subsystem. The root cause is that org.apache.karaf.shell.dev.BundleWatcher uses System.out.println() to emit this message, which is routed by Gogo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1199) dev:watch command issues "[WATCH]"
announcements only to the issuing shell
Posted by "Jean-Baptiste Onofré (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré updated KARAF-1199:
----------------------------------------
Fix Version/s: (was: 3.0.0)
3.1.0
> dev:watch command issues "[WATCH]" announcements only to the issuing shell
> --------------------------------------------------------------------------
>
> Key: KARAF-1199
> URL: https://issues.apache.org/jira/browse/KARAF-1199
> Project: Karaf
> Issue Type: Bug
> Components: karaf-shell
> Affects Versions: 2.2.4
> Reporter: Chris Dolan
> Assignee: Jean-Baptiste Onofré
> Priority: Trivial
> Fix For: 2.2.6, 3.1.0
>
>
> If I issue a "dev:watch *" command and later update one of my snapshot bundles, the announcement of that change is emitted in the context of the shell that issued the command. That is, if I issue it in the Gogo ssh shell, then the "[WATCH] ..." announcement goes to that shell. If I trigger the Watch service programmatically, then the announcement goes to the system console.
> Instead, I think the announcement should go to the log subsystem. The root cause is that org.apache.karaf.shell.dev.BundleWatcher uses System.out.println() to emit this message, which is routed by Gogo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira