You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "mattrpav (via GitHub)" <gi...@apache.org> on 2026/03/23 14:29:05 UTC
[PR] [#1823] Align DestinationView and DestinationViewMBean [activemq]
mattrpav opened a new pull request, #1824:
URL: https://github.com/apache/activemq/pull/1824
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] [#1823] Align DestinationView and DestinationViewMBean [activemq]
Posted by "mattrpav (via GitHub)" <gi...@apache.org>.
mattrpav commented on code in PR #1824:
URL: https://github.com/apache/activemq/pull/1824#discussion_r2976096124
##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/DestinationView.java:
##########
@@ -136,6 +136,12 @@ public long getStoreMessageSize() {
return messageStore != null ? messageStore.getMessageStoreStatistics().getMessageSize().getTotalSize() : 0;
}
+ @Override
+ public long getMessagesCachedCount() {
+ return destination.getDestinationStatistics().getMessagesCached().getCount();
+ }
+
+ @Deprecated(forRemoval = true) // see: getMessagesCachedCount() instead. This method name is inconsistent
Review Comment:
Currently, there is no 'getMessagesCached()' method. This PR adds the new field method with aligned naming
```
public long getMessagesCachedCount();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] [#1823] Align DestinationView and DestinationViewMBean [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1824:
URL: https://github.com/apache/activemq/pull/1824#discussion_r2976348084
##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/DestinationView.java:
##########
@@ -136,6 +136,12 @@ public long getStoreMessageSize() {
return messageStore != null ? messageStore.getMessageStoreStatistics().getMessageSize().getTotalSize() : 0;
}
+ @Override
+ public long getMessagesCachedCount() {
+ return destination.getDestinationStatistics().getMessagesCached().getCount();
+ }
+
+ @Deprecated(forRemoval = true) // see: getMessagesCachedCount() instead. This method name is inconsistent
Review Comment:
Oh you renamed the MBean operation. It makes sense. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] [#1823] Align DestinationView and DestinationViewMBean [activemq]
Posted by "mattrpav (via GitHub)" <gi...@apache.org>.
mattrpav merged PR #1824:
URL: https://github.com/apache/activemq/pull/1824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] [#1823] Align DestinationView and DestinationViewMBean [activemq]
Posted by "mattrpav (via GitHub)" <gi...@apache.org>.
mattrpav commented on code in PR #1824:
URL: https://github.com/apache/activemq/pull/1824#discussion_r2976096124
##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/DestinationView.java:
##########
@@ -136,6 +136,12 @@ public long getStoreMessageSize() {
return messageStore != null ? messageStore.getMessageStoreStatistics().getMessageSize().getTotalSize() : 0;
}
+ @Override
+ public long getMessagesCachedCount() {
+ return destination.getDestinationStatistics().getMessagesCached().getCount();
+ }
+
+ @Deprecated(forRemoval = true) // see: getMessagesCachedCount() instead. This method name is inconsistent
Review Comment:
There is no 'getMessagesCached()' method. This PR adds the new field method with aligned naming
```
public long getMessagesCachedCount();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] [#1823] Align DestinationView and DestinationViewMBean [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1824:
URL: https://github.com/apache/activemq/pull/1824#discussion_r2975676111
##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/DestinationView.java:
##########
@@ -136,6 +136,12 @@ public long getStoreMessageSize() {
return messageStore != null ? messageStore.getMessageStoreStatistics().getMessageSize().getTotalSize() : 0;
}
+ @Override
+ public long getMessagesCachedCount() {
+ return destination.getDestinationStatistics().getMessagesCached().getCount();
+ }
+
+ @Deprecated(forRemoval = true) // see: getMessagesCachedCount() instead. This method name is inconsistent
Review Comment:
I agree with `@Deprecated` here. For consistency, I suggest to also deprecated `getMessagesCached()` method in the MBean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact