You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "kayx23 (via GitHub)" <gi...@apache.org> on 2023/07/25 08:34:40 UTC

[GitHub] [apisix] kayx23 opened a new pull request, #9895: docs: update placeholder names of certificates in decoupled mode

kayx23 opened a new pull request, #9895:
URL: https://github.com/apache/apisix/pull/9895

   ### Description
   
   Update the placeholders for certificates that are currently `/path/to/ca-cert` in the decoupled mode documentation to be more accurate.
   
   Fixes #9883 
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [x] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] monkeyDluffy6017 merged pull request #9895: docs: update certificate names in decoupled mode and add configurations for different deployment modes to `config-default.yaml`

Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 merged PR #9895:
URL: https://github.com/apache/apisix/pull/9895


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] moonming commented on pull request #9895: docs: update certificate names in decoupled mode

Posted by "moonming (via GitHub)" <gi...@apache.org>.
moonming commented on PR #9895:
URL: https://github.com/apache/apisix/pull/9895#issuecomment-1649474596

   
   
   
   > It doesn't include the configurations of **decoupled mode**, so you won't find these configurations in there.
   
   if so how do developers know decoupled mode configurations?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] moonming commented on pull request #9895: docs: update certificate names in decoupled mode

Posted by "moonming (via GitHub)" <gi...@apache.org>.
moonming commented on PR #9895:
URL: https://github.com/apache/apisix/pull/9895#issuecomment-1649415320

   Do we need to update https://github.com/apache/apisix/blob/master/conf/config-default.yaml too? I do not find these configures in this file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] kayx23 commented on pull request #9895: docs: update certificate names in decoupled mode

Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on PR #9895:
URL: https://github.com/apache/apisix/pull/9895#issuecomment-1649702591

   Added configurations to `config-default.yaml`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] kayx23 commented on pull request #9895: docs: update certificate names in decoupled mode

Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on PR #9895:
URL: https://github.com/apache/apisix/pull/9895#issuecomment-1649452022

   It looks to me that `config-default.yaml` includes only the configurations of **traditional mode** by default.
   
   It doesn't include the configurations of **decoupled mode**, so you won't find these configurations in there.
   
   It probably doesn't make sense to include both (even with one commented out) in that file because these deployment modes and configurations are conceptually mutually exclusive.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org