You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/10/12 13:02:05 UTC
[I] Replace `.size() > 0` with `!.isempty()` [iceberg]
Fokko opened a new issue, #8810:
URL: https://github.com/apache/iceberg/issues/8810
### Feature Request / Improvement
Suggestion by IDEA:
I think this is nice because `isEmpty` should be faster. We also have different implementations in `PartitionSet.java`:
```java
@Override
public int size() {
return partitionSetById.values().stream().mapToInt(Set::size).sum();
}
@Override
public boolean isEmpty() {
return partitionSetById.values().stream().allMatch(Set::isEmpty);
}
```
### Query engine
Other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Replace `.size() > 0` with `!.isempty()` [iceberg]
Posted by "PickBas (via GitHub)" <gi...@apache.org>.
PickBas commented on issue #8810:
URL: https://github.com/apache/iceberg/issues/8810#issuecomment-1759962395
@Fokko Will be done. Could you assign the issue to me, if you don't mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Replace `.size() > 0` with `!.isempty()` [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on issue #8810:
URL: https://github.com/apache/iceberg/issues/8810#issuecomment-1759954274
There are quite a few:
```
./core/src/main/java/org/apache/iceberg/BaseDistributedDataScan.java: boolean mayHaveEqualityDeletes = deleteManifests.size() > 0 && mayHaveEqualityDeletes(snapshot);
./core/src/main/java/org/apache/iceberg/util/PartitionUtil.java: if (partitionType.fields().size() > 0) {
./core/src/main/java/org/apache/iceberg/TableMetadata.java: || (discardChanges && changes.size() > 0)
./core/src/main/java/org/apache/iceberg/io/DeleteWriteResult.java: return referencedDataFiles != null && referencedDataFiles.size() > 0;
./core/src/main/java/org/apache/iceberg/SnapshotSummary.java: setIf(changedPartitions.size() > 0, builder, PARTITION_SUMMARY_PROP, "true");
./core/src/main/java/org/apache/iceberg/FastAppend.java: if (newManifests == null && newFiles.size() > 0) {
./core/src/main/java/org/apache/iceberg/actions/RewritePositionDeletesGroup.java: Preconditions.checkArgument(tasks.size() > 0, "Tasks must not be empty");
./core/src/main/java/org/apache/iceberg/actions/BaseCommitService.java: while (running.get() || completedRewrites.size() > 0 || inProgressCommits.size() > 0) {
./core/src/main/java/org/apache/iceberg/actions/BaseCommitService.java: if (!running.get() && completedRewrites.size() > 0) {
./core/src/main/java/org/apache/iceberg/actions/BaseCommitService.java: boolean writingComplete = !running.get() && completedRewrites.size() > 0;
./core/src/main/java/org/apache/iceberg/view/ViewMetadata.java: Preconditions.checkArgument(versions.size() > 0, "Invalid view: no versions were added");
./core/src/main/java/org/apache/iceberg/PositionDeletesTable.java: if (partitionType.fields().size() > 0) {
./core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java: if (deletedDataFiles.size() > 0) {
./core/src/main/java/org/apache/iceberg/ManifestFilterManager.java: return deletePaths.size() > 0
./core/src/main/java/org/apache/iceberg/ManifestFilterManager.java: || dropPartitions.size() > 0;
./core/src/main/java/org/apache/iceberg/ManifestFilterManager.java: if (dropPartitions.size() > 0) {
./core/src/main/java/org/apache/iceberg/ManifestFilterManager.java: } else if (deletePaths.size() > 0) {
./core/src/main/java/org/apache/iceberg/ReachableFileUtil.java: if (metadataLogEntries.size() > 0) {
./core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: return newDataFiles.size() > 0;
./core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: return newDeleteFilesBySpec.size() > 0;
./core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: if (newDataFiles.size() > 0) {
./core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: if (hasNewDeleteFiles && cachedNewDeleteManifests.size() > 0) {
./core/src/main/java/org/apache/iceberg/BaseRewriteFiles.java: if (replacedDataFiles.size() > 0) {
./core/src/main/java/org/apache/iceberg/ContentFileParser.java: return partitionData != null && partitionData.size() > 0;
./core/src/main/java/org/apache/iceberg/BaseIncrementalChangelogScan.java: if (snapshot.deleteManifests(table().io()).size() > 0) {
./aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockLocalStore.java: return buckets.size() > 0 ? buckets.get(0) : null;
./mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: if (dataFiles.size() > 0) {
./mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java: if (dataFiles.size() > 0) {
./flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java: if (equalityFieldColumns != null && equalityFieldColumns.size() > 0) {
./flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/DataStatisticsCoordinator.java: gateways[subtaskIndex].size() > 0,
./flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java: if (equalityFieldColumns != null && equalityFieldColumns.size() > 0) {
./flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java: if (equalityFieldColumns != null && equalityFieldColumns.size() > 0) {
./delta-lake/src/main/java/org/apache/iceberg/delta/BaseSnapshotDeltaLakeTableAction.java: if (filesToAdd.size() > 0 && filesToRemove.size() > 0) {
./delta-lake/src/main/java/org/apache/iceberg/delta/BaseSnapshotDeltaLakeTableAction.java: } else if (filesToAdd.size() > 0) {
./delta-lake/src/main/java/org/apache/iceberg/delta/BaseSnapshotDeltaLakeTableAction.java: } else if (filesToRemove.size() > 0) {
./hive3/src/main/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java: return hasBase || deltas.size() > 0;
./api/src/main/java/org/apache/iceberg/expressions/ResidualEvaluator.java: if (spec.fields().size() > 0) {
./aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogNamespace.java: Assert.assertTrue(namespaceList.size() > 0);
./parquet/src/main/java/org/apache/iceberg/parquet/ParquetBloomRowGroupFilter.java: if (filterRefs.size() > 0 && Sets.intersection(fieldsWithBloomFilter, filterRefs).isEmpty()) {
./data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java: return Lists.newArrayList(reader).size() > 0;
./data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilterTypes.java: return Lists.newArrayList(reader).size() > 0;
./spark/v3.3/spark/src/test/java/org/apache/iceberg/TestScanTaskSerialization.java: Assert.assertTrue("Task group can't be empty", taskGroup.tasks().size() > 0);
./spark/v3.3/spark/src/test/java/org/apache/iceberg/TestScanTaskSerialization.java: Assert.assertTrue("Task group can't be empty", taskGroup.tasks().size() > 0);
./spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java: Assert.assertTrue("Empty delete file found", rows.size() > 0);
./spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results1.size() > 0);
./spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results2.size() > 0);
./spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results1.size() > 0);
./spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results2.size() > 0);
./spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/ScanTaskSetManager.java: tasks != null && tasks.size() > 0, "Cannot stage null or empty tasks");
./spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkDataFile.java: if (wrappedPartition.size() > 0) {
./spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatch.java: && expectedSchema.columns().size() > 0
./spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewriteBuilder.java: tasks != null && tasks.size() > 0, "No scan tasks found for %s", fileSetId);
./spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java: if (partition.size() > 0) {
./spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/RewritePositionDeleteFilesSparkAction.java: if (partition.size() > 0) {
./spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/SparkBinPackPositionDeletesRewriter.java: Preconditions.checkArgument(group.size() > 0, "Empty group");
./spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/SparkZOrderDataRewriter.java: validZOrderColNames.size() > 0,
./spark/v3.4/spark/src/test/java/org/apache/iceberg/TestScanTaskSerialization.java: Assert.assertTrue("Task group can't be empty", taskGroup.tasks().size() > 0);
./spark/v3.4/spark/src/test/java/org/apache/iceberg/TestScanTaskSerialization.java: Assert.assertTrue("Task group can't be empty", taskGroup.tasks().size() > 0);
./spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java: Assert.assertTrue("Empty delete file found", rows.size() > 0);
./spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results1.size() > 0);
./spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results2.size() > 0);
./spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results1.size() > 0);
./spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results2.size() > 0);
./spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/ScanTaskSetManager.java: tasks != null && tasks.size() > 0, "Cannot stage null or empty tasks");
./spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkDataFile.java: if (wrappedPartition.size() > 0) {
./spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewriteBuilder.java: tasks != null && tasks.size() > 0, "No scan tasks found for %s", fileSetId);
./spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java: if (partition.size() > 0) {
./spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/RewritePositionDeleteFilesSparkAction.java: if (partition.size() > 0) {
./spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/SparkBinPackPositionDeletesRewriter.java: Preconditions.checkArgument(group.size() > 0, "Empty group");
./spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/SparkZOrderDataRewriter.java: validZOrderColNames.size() > 0,
./spark/v3.5/spark/src/test/java/org/apache/iceberg/TestScanTaskSerialization.java: Assert.assertTrue("Task group can't be empty", taskGroup.tasks().size() > 0);
./spark/v3.5/spark/src/test/java/org/apache/iceberg/TestScanTaskSerialization.java: Assert.assertTrue("Task group can't be empty", taskGroup.tasks().size() > 0);
./spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java: Assert.assertTrue("Empty delete file found", rows.size() > 0);
./spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results1.size() > 0);
./spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results2.size() > 0);
./spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results1.size() > 0);
./spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results2.size() > 0);
./spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/ScanTaskSetManager.java: tasks != null && tasks.size() > 0, "Cannot stage null or empty tasks");
./spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkDataFile.java: if (wrappedPartition.size() > 0) {
./spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewriteBuilder.java: tasks != null && tasks.size() > 0, "No scan tasks found for %s", fileSetId);
./spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java: if (partition.size() > 0) {
./spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewritePositionDeleteFilesSparkAction.java: if (partition.size() > 0) {
./spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/SparkBinPackPositionDeletesRewriter.java: Preconditions.checkArgument(group.size() > 0, "Empty group");
./spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/SparkZOrderDataRewriter.java: validZOrderColNames.size() > 0,
./spark/v3.2/spark/src/test/java/org/apache/iceberg/TestScanTaskSerialization.java: Assert.assertTrue("Task group can't be empty", taskGroup.tasks().size() > 0);
./spark/v3.2/spark/src/test/java/org/apache/iceberg/TestScanTaskSerialization.java: Assert.assertTrue("Task group can't be empty", taskGroup.tasks().size() > 0);
./spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results1.size() > 0);
./spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results2.size() > 0);
./spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results1.size() > 0);
./spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results2.size() > 0);
./spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: Assert.assertTrue(results.size() > 0);
./spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkDataFile.java: if (wrappedPartition.size() > 0) {
./spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatch.java: expectedSchema.columns().size() > 0
./spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java: if (fileGroups.size() > 0) {
./spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java: if (partition.size() > 0) {
./spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/FileScanTaskSetManager.java: tasks != null && tasks.size() > 0, "Cannot stage null or empty tasks");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Replace `.size() > 0` with `!.isempty()` [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on issue #8810:
URL: https://github.com/apache/iceberg/issues/8810#issuecomment-1768138708
Thanks for fixing this one @PickBas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Replace `.size() > 0` with `!.isempty()` [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko closed issue #8810: Replace `.size() > 0` with `!.isempty()`
URL: https://github.com/apache/iceberg/issues/8810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Replace `.size() > 0` with `!.isempty()` [iceberg]
Posted by "PickBas (via GitHub)" <gi...@apache.org>.
PickBas commented on issue #8810:
URL: https://github.com/apache/iceberg/issues/8810#issuecomment-1760006978
@Fokko I have changed everywhere in core/* module from `size()` to `isEmpty()` except _ContentFileParser.java_. In order to move away from `.size() > 0` it is required to add the `isEmpty()` method to the `StructLike` interface. This interface has 29 implementations. Do I need to add the `isEmpty()` method to the aforementioned interface or leave it as is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org