[GitHub] [skywalking] wu-sheng commented on a change in pull request #4371: fix topology node type unknown.

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #4371: fix topology node type unknown.
URL: https://github.com/apache/skywalking/pull/4371#discussion_r379899569
 
 

 ##########
 File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/TopologyBuilder.java
 ##########
 @@ -78,11 +79,20 @@ Topology build(List<Call.CallDetail> serviceRelationClientCalls, List<Call.CallD
                 nodes.put(source.getSequence(), buildNode(source));
             }
 
-            if (!nodes.containsKey(target.getSequence())) {
-                nodes.put(target.getSequence(), buildNode(target));
+            int sequence = target.getSequence();
+            if (nodes.containsKey(sequence)) {
+                //if node type is Unknown, but some targer know node type, so update the node type.
 
 Review comment:
   ```suggestion
                   //if node type is Unknown, but the target may know the node type.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services