You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/02/05 06:04:08 UTC

[GitHub] [beam] tvalentyn commented on a change in pull request #16517: BEAM-13439 Type annotation for ptransform_fn

tvalentyn commented on a change in pull request #16517:
URL: https://github.com/apache/beam/pull/16517#discussion_r800006634



##########
File path: sdks/python/apache_beam/transforms/ptransform.py
##########
@@ -1002,7 +1002,7 @@ def default_label(self):
     return label_from_callable(self._fn)
 
 
-def ptransform_fn(fn):
+def ptransform_fn(fn) -> Callable[..., _PTransformFnPTransform]:

Review comment:
       We currently use annotations with explicit `# type:` comment in annotations. We added  them back when still supporting Python 2, and planned a rewrite into native Py3 type hints, but looks like that didn't land yet.
   For consistency reasons, could you please you try the old style annotation and see if that works for your purposes, @SandyChapman ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org