You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by "mawiesne (via GitHub)" <gi...@apache.org> on 2023/02/23 13:26:04 UTC

[GitHub] [opennlp-sandbox] mawiesne opened a new pull request, #87: Name constants according to JNC

mawiesne opened a new pull request, #87:
URL: https://github.com/apache/opennlp-sandbox/pull/87

   - adjusts non-compliant naming of constant fields so that capitalized name is used
   - adjusts visibility of some fields to respect information hiding principle
   - fixes incorrect indentation in some classes
   - removes unused imports along the path
   
   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [ ] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via `mvn clean install` at the root opennlp-sandbox folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](https://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp-sandbox folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp-sandbox folder?
   
   ### For documentation related changes:
   - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne merged pull request #87: Name constants according to JNC

Posted by "mawiesne (via GitHub)" <gi...@apache.org>.
mawiesne merged PR #87:
URL: https://github.com/apache/opennlp-sandbox/pull/87


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on pull request #87: Name constants according to JNC

Posted by "mawiesne (via GitHub)" <gi...@apache.org>.
mawiesne commented on PR #87:
URL: https://github.com/apache/opennlp-sandbox/pull/87#issuecomment-1441790316

   @kinow This is a follow-up PR for the issue with naming of constants, found/discussed recently.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [opennlp-sandbox] mawiesne commented on pull request #87: Name constants according to JNC

Posted by "mawiesne (via GitHub)" <gi...@apache.org>.
mawiesne commented on PR #87:
URL: https://github.com/apache/opennlp-sandbox/pull/87#issuecomment-1441869796

   > CI is broken due to flaky tests
   
   I'll dig into the flakyness soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org