You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "porunov (via GitHub)" <gi...@apache.org> on 2023/04/19 13:17:09 UTC
[GitHub] [tinkerpop] porunov opened a new pull request, #2031: Make CoalesceStep extensible
porunov opened a new pull request, #2031:
URL: https://github.com/apache/tinkerpop/pull/2031
_This PR implements part of https://github.com/apache/tinkerpop/pull/2027 . Close this PR without merging in case https://github.com/apache/tinkerpop/pull/2027 is merged._
This PR will make possible to extend `CoalesceStep` which is needed for https://github.com/JanusGraph/janusgraph/issues/2996 . This will help creating a replacement step for original CoalesceStep with optimizations in place.
Related issue: https://issues.apache.org/jira/browse/TINKERPOP-2927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #2031: Make CoalesceStep extensible
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2031:
URL: https://github.com/apache/tinkerpop/pull/2031#issuecomment-1516930089
VOTE+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] porunov commented on pull request #2031: Make CoalesceStep extensible
Posted by "porunov (via GitHub)" <gi...@apache.org>.
porunov commented on PR #2031:
URL: https://github.com/apache/tinkerpop/pull/2031#issuecomment-1516968905
> I'm guessing you just want to override the flatMap() method? FlatMapStep seems to be fairly stable.
Yes, that's right. The idea is to change `flatMap()` method to apply multi-query JanusGraph optimization when possible to wrapped traversals under `CoalesceStep`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] kenhuuu commented on pull request #2031: Make CoalesceStep extensible
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #2031:
URL: https://github.com/apache/tinkerpop/pull/2031#issuecomment-1516912655
I'm guessing you just want to override the flatMap() method? FlatMapStep seems to be fairly stable.
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on pull request #2031: Make CoalesceStep extensible
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #2031:
URL: https://github.com/apache/tinkerpop/pull/2031#issuecomment-1516987464
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] porunov commented on pull request #2031: Make CoalesceStep extensible
Posted by "porunov (via GitHub)" <gi...@apache.org>.
porunov commented on PR #2031:
URL: https://github.com/apache/tinkerpop/pull/2031#issuecomment-1514754929
The failed test is most likely flaky:
```
Error: Tests run: 1089, Failures: 1, Errors: 0, Skipped: 502, Time elapsed: 17.124 s <<< FAILURE! - in org.apache.tinkerpop.gremlin.tinkergraph.TinkerGraphComputerFeatureTest
Error: g_V_hasXname_rippleX_inXcreatedX_peerPressure_withXedges_outEX_withyXpropertyName_clusterX_repeatXunionXidentity__bothX_timesX2X_dedup_valueMapXname_clusterX(Step - peerPressure()) Time elapsed: 0.047 s <<< FAILURE!
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] kenhuuu merged pull request #2031: Make CoalesceStep extensible
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu merged PR #2031:
URL: https://github.com/apache/tinkerpop/pull/2031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org