[GitHub] [metron] mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2

[GitBox <gi...@apache.org>]

mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2
URL: https://github.com/apache/metron/pull/1458#discussion_r311129722
 
 

 ##########
 File path: metron-analytics/metron-profiler-storm/src/test/java/org/apache/metron/profiler/storm/integration/ProfilerIntegrationTest.java
 ##########
 @@ -503,21 +496,29 @@ public void setup() {
       put(PROFILER_SALT_DIVISOR.getKey(), saltDivisor);
     }};
 
+    Context context = new Context.Builder()
+            .with(Context.Capabilities.GLOBAL_CONFIG, () -> global)
+            .build();
+
+    // create the GET_PROFILE function
+    GetProfile getProfileFunction = new GetProfile()
+            .withProfilerClientFactory(new HBaseProfilerClientFactory(new FakeHBaseClientFactory()));
 
 Review comment:
   Just so I'm clear, by the end of the upgrade we will no longer have the existing mock hbase, just the new fake client?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services