You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/05/04 15:45:59 UTC

[GitHub] [trafficcontrol] rawlinp opened a new pull request #4683: Remove audit logging from POST /serverchecks endpoint

rawlinp opened a new pull request #4683:
URL: https://github.com/apache/trafficcontrol/pull/4683


   #910  What does this PR (Pull Request) do?
   Since this endpoint gets called once a minute per server, this can
   seriously spam the audit log.
   
   - [x] This PR is not related to any issue
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   Run the TO API tests, verify they pass, check to make sure no "Server Check was successfully updated" audit logs were created.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   
   - master
   - 4.1.0-RC0
   - 4.0.0
   
   ## The following criteria are ALL met by this PR
   
   - [x] Minor audit log removal, no tests necessary
   - [x] Minor audit log removal, no docs necessary
   - [x] This PR includes an update to CHANGELOG.md
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] mattjackson220 commented on pull request #4683: Remove audit logging from POST /serverchecks endpoint

Posted by GitBox <gi...@apache.org>.
mattjackson220 commented on pull request #4683:
URL: https://github.com/apache/trafficcontrol/pull/4683#issuecomment-623571496


   Looks good! API tests pass, unit tests pass, and audit logs were not created


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org