You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Sai Boorlagadda <sb...@pivotal.io> on 2016/02/03 23:45:35 UTC

Review Request 43155: GEODE-891 : DataType needs better unit test coverage

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43155/
-----------------------------------------------------------

Review request for geode and Darrel Schneider.


Repository: geode


Description
-------

* Added tests for missing cases
* Removed SQLF case


Diffs
-----

  gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/DataType.java c42304dfc4c6396c52817bfe6d859cad87148e58 
  gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/DataTypeJUnitTest.java 6c12472552862eae70ab238a109f41394f059af3 

Diff: https://reviews.apache.org/r/43155/diff/


Testing
-------

precheckin in progress


Thanks,

Sai Boorlagadda


Re: Review Request 43155: GEODE-891 : DataType needs better unit test coverage

Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43155/#review118047
-----------------------------------------------------------


Ship it!




Ship It!

- Darrel Schneider


On Feb. 3, 2016, 2:45 p.m., Sai Boorlagadda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43155/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 2:45 p.m.)
> 
> 
> Review request for geode and Darrel Schneider.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> * Added tests for missing cases
> * Removed SQLF case
> 
> 
> Diffs
> -----
> 
>   gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/DataType.java c42304dfc4c6396c52817bfe6d859cad87148e58 
>   gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/DataTypeJUnitTest.java 6c12472552862eae70ab238a109f41394f059af3 
> 
> Diff: https://reviews.apache.org/r/43155/diff/
> 
> 
> Testing
> -------
> 
> precheckin in progress
> 
> 
> Thanks,
> 
> Sai Boorlagadda
> 
>