You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/14 17:32:29 UTC

[GitHub] [spark] vitaliili-db commented on pull request #38242: [SPARK-40792] Helper object to get SQL configs for errors

vitaliili-db commented on PR #38242:
URL: https://github.com/apache/spark/pull/38242#issuecomment-1279282246

   > > Allows injection of vendor specific SQL config keys, e.g. Databricks ansi_mode instead of spark.sql.ansi.enabled
   > 
   > @vitaliili-db Can't you just add an alternative for the config, see for example
   > 
   > https://github.com/apache/spark/blob/8251f876fd6a0300bbdac415091786dda3957532/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala#L3617
   
   @MaxGekk For defining config `withAlternative` will work, but this logic is for retrieval. I.e. we want to show correct configuration key in error message depending in which context an error occurred.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org