You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@ip-10-146-233-104.ec2.internal> on 2016/01/15 21:31:09 UTC

[kudu-CR] Convert collection iteration to c++11 foreach

Hello Adar Dembo, Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/1799

to review the following change.

Change subject: Convert collection iteration to c++11 foreach
......................................................................

Convert collection iteration to c++11 foreach

This patch was created using the clang-modernize tool with a few manual tweaks.

Change-Id: Ie81b207672e9da628da95630e22dc73811740589
---
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/codegen/module_builder.cc
M src/kudu/common/id_mapping.h
M src/kudu/common/partition.cc
M src/kudu/common/row.h
M src/kudu/common/schema.cc
M src/kudu/consensus/log_anchor_registry-test.cc
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/log_util.cc
M src/kudu/consensus/raft_consensus_state.cc
M src/kudu/gutil/charmap.h
M src/kudu/gutil/map-util.h
M src/kudu/gutil/strings/escaping.cc
M src/kudu/gutil/strings/join.cc
M src/kudu/gutil/strings/serialize.cc
M src/kudu/gutil/strings/split.cc
M src/kudu/gutil/strings/split.h
M src/kudu/gutil/strings/split_internal.h
M src/kudu/gutil/strings/strip.cc
M src/kudu/gutil/strings/util.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/mini_cluster.cc
M src/kudu/rpc/mt-rpc-test.cc
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/mt-rowset_delta_compaction-test.cc
M src/kudu/tablet/mvcc.cc
M src/kudu/tablet/tablet-test-util.h
M src/kudu/util/auto_release_pool.h
M src/kudu/util/blocking_queue-test.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/mem_tracker.cc
M src/kudu/util/memenv/memenv.cc
M src/kudu/util/rle-test.cc
M src/kudu/util/string_case.cc
34 files changed, 155 insertions(+), 186 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/1799/1
-- 
To view, visit http://gerrit.cloudera.org:8080/1799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie81b207672e9da628da95630e22dc73811740589
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>