You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/08/07 20:46:51 UTC
[GitHub] [samza] thunderstumpges opened a new pull request #1131: SAMZA-2295
: records-lag based topic metrics not working for topics with periods (dot,
'.') in them
thunderstumpges opened a new pull request #1131: SAMZA-2295 : records-lag based topic metrics not working for topics with periods (dot, '.') in them
URL: https://github.com/apache/samza/pull/1131
Fix for topic lag metrics where topic contains period (.)
`messages-behind-high-watermark` and `high-watermark` are calculated from kafka's `records-lag` consumer metric. In version 1.1 or so, when metrics moved from including the topic name in the metric name to using tags, they added a replacement of period to underscore. See commit :
https://github.com/apache/kafka/commit/5d81639907869ce7355c40d2bac176a655e52074#diff-b45245913eaae46aa847d2615d62cde0R1331
When Samza refactored to match this, the same replacement was not made, so the lookup of the "records-lag" metric in KafkaConsumerProxy fails to find a match.
The related commit on Samza is here:
https://github.com/apache/samza/commit/01c06055057e8c260e73bf3f7db7b9eb53af3745#diff-b56db493dfdd2fd2d471f6df342fe661R400
The fix is a simple replacement added to the line above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services