You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/21 06:14:03 UTC

[GitHub] [shardingsphere] Lucas-307 opened a new pull request #6963: 0819.1407 6813

Lucas-307 opened a new pull request #6963:
URL: https://github.com/apache/shardingsphere/pull/6963


   Fixes #6813.
   
   Changes proposed in this pull request:
   - add unit test for shardingsphere-scaling
   - refactor some codes.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #6963: add unit test for shardingsphere-scaling

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #6963:
URL: https://github.com/apache/shardingsphere/pull/6963


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls commented on pull request #6963: add unit test for shardingsphere-scaling

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #6963:
URL: https://github.com/apache/shardingsphere/pull/6963#issuecomment-678083555


   ## Pull Request Test Coverage Report for [Build 13959](https://coveralls.io/builds/32906502)
   
   * **25** of **29**   **(86.21%)**  changed or added relevant lines in **14** files are covered.
   * **90** unchanged lines in **2** files lost coverage.
   * Overall coverage increased (+**0.8%**) to **61.104%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/metadata/JdbcUri.java](https://coveralls.io/builds/32906502/source?filename=shardingsphere-scaling%2Fshardingsphere-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fscaling%2Fcore%2Fmetadata%2FJdbcUri.java#L78) | 0 | 1 | 0.0%
   | [shardingsphere-scaling/shardingsphere-scaling-postgresql/src/main/java/org/apache/shardingsphere/scaling/postgresql/PostgreSQLWalDumper.java](https://coveralls.io/builds/32906502/source?filename=shardingsphere-scaling%2Fshardingsphere-scaling-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fscaling%2Fpostgresql%2FPostgreSQLWalDumper.java#L84) | 0 | 1 | 0.0%
   | [shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/utils/ThreadUtil.java](https://coveralls.io/builds/32906502/source?filename=shardingsphere-scaling%2Fshardingsphere-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fscaling%2Fcore%2Futils%2FThreadUtil.java#L23) | 3 | 5 | 60.0%
   <!-- | **Total:** | **25** | **29** | **86.21%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-scaling/shardingsphere-scaling-mysql/src/main/java/org/apache/shardingsphere/scaling/mysql/MySQLScalingEntry.java](https://coveralls.io/builds/32906502/source?filename=shardingsphere-scaling%2Fshardingsphere-scaling-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fscaling%2Fmysql%2FMySQLScalingEntry.java#L31) | 3 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDMLVisitor.java](https://coveralls.io/builds/32906502/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDMLVisitor.java#L226) | 87 | 0% |
   <!-- | **Total:** | **90** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/32906502/badge)](https://coveralls.io/builds/32906502) |
   | :-- | --: |
   | Change from base [Build 13958](https://coveralls.io/builds/32906152): |  0.8% |
   | Covered Lines: | 13950 |
   | Relevant Lines: | 22830 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org