You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "ldube (via GitHub)" <gi...@apache.org> on 2023/05/19 12:23:39 UTC

[GitHub] [nuttx] ldube commented on a diff in pull request #9331: usbhost: Can now handle multiple interface descriptors.

ldube commented on code in PR #9331:
URL: https://github.com/apache/nuttx/pull/9331#discussion_r1198899414


##########
drivers/usbhost/usbhost_enumerate.c:
##########
@@ -51,7 +51,9 @@ static void usbhost_putle16(uint8_t *dest, uint16_t val);
 static inline int usbhost_devdesc(const struct usb_devdesc_s *devdesc,
               FAR struct usbhost_id_s *id);
 static inline int usbhost_configdesc(const uint8_t *configdesc, int desclen,
-              FAR struct usbhost_id_s *id);
+                                     const uint8_t start_ifnum,

Review Comment:
   > 
   Please give a reason for removing const on what is supposed to be a readonly variable.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org