You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Erik Bi <bi...@cn.ibm.com> on 2012/08/08 04:08:30 UTC
Re: Review Request: Adding support for
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5973/
-----------------------------------------------------------
(Updated Aug. 8, 2012, 2:08 a.m.)
Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
Description
-------
According to the spec, you can define a in-line variable via <os:Var>
http://opensocial-resources.googlecode.com/svn/spec/2.0.1/OpenSocial-Templating.xml#rfc.section.8.2
Seems this feature is not implemented in Shindig Java version right now (seen from the code, it's implemented in PHP version.
This patch is to add os:Var support for shindig template
This addresses bug shindig-1737.
https://issues.apache.org/jira/browse/shindig-1737
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/templates/VarTag.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java 1366998
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/VarTagHandler.java PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/VarTagHandlerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/5973/diff/
Testing
-------
Thanks,
Erik Bi
Re: Review Request: Adding support for
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5973/#review10019
-----------------------------------------------------------
Ship it!
- Dan Dumont
On Aug. 8, 2012, 2:08 a.m., Erik Bi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5973/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2012, 2:08 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
>
>
> Description
> -------
>
> According to the spec, you can define a in-line variable via <os:Var>
>
> http://opensocial-resources.googlecode.com/svn/spec/2.0.1/OpenSocial-Templating.xml#rfc.section.8.2
>
> Seems this feature is not implemented in Shindig Java version right now (seen from the code, it's implemented in PHP version.
>
> This patch is to add os:Var support for shindig template
>
>
> This addresses bug shindig-1737.
> https://issues.apache.org/jira/browse/shindig-1737
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/templates/VarTag.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java 1366998
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/VarTagHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/VarTagHandlerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5973/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Bi
>
>
Re: Review Request: Adding support for
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5973/#review10270
-----------------------------------------------------------
Ship it!
Committed r1372882
Please close the review.
- Dan Dumont
On Aug. 8, 2012, 2:08 a.m., Erik Bi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5973/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2012, 2:08 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
>
>
> Description
> -------
>
> According to the spec, you can define a in-line variable via <os:Var>
>
> http://opensocial-resources.googlecode.com/svn/spec/2.0.1/OpenSocial-Templating.xml#rfc.section.8.2
>
> Seems this feature is not implemented in Shindig Java version right now (seen from the code, it's implemented in PHP version.
>
> This patch is to add os:Var support for shindig template
>
>
> This addresses bug shindig-1737.
> https://issues.apache.org/jira/browse/shindig-1737
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/templates/VarTag.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java 1366998
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/VarTagHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/VarTagHandlerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5973/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Bi
>
>
Re: Review Request: Adding support for
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5973/#review10054
-----------------------------------------------------------
Ship it!
Ship It!
- Ryan Baxter
On Aug. 8, 2012, 2:08 a.m., Erik Bi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5973/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2012, 2:08 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
>
>
> Description
> -------
>
> According to the spec, you can define a in-line variable via <os:Var>
>
> http://opensocial-resources.googlecode.com/svn/spec/2.0.1/OpenSocial-Templating.xml#rfc.section.8.2
>
> Seems this feature is not implemented in Shindig Java version right now (seen from the code, it's implemented in PHP version.
>
> This patch is to add os:Var support for shindig template
>
>
> This addresses bug shindig-1737.
> https://issues.apache.org/jira/browse/shindig-1737
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/templates/VarTag.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java 1366998
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/VarTagHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/VarTagHandlerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5973/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Bi
>
>
Re: Review Request: Adding support for
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5973/#review10055
-----------------------------------------------------------
Ship it!
+1
- Henry Saputra
On Aug. 8, 2012, 2:08 a.m., Erik Bi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5973/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2012, 2:08 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
>
>
> Description
> -------
>
> According to the spec, you can define a in-line variable via <os:Var>
>
> http://opensocial-resources.googlecode.com/svn/spec/2.0.1/OpenSocial-Templating.xml#rfc.section.8.2
>
> Seems this feature is not implemented in Shindig Java version right now (seen from the code, it's implemented in PHP version.
>
> This patch is to add os:Var support for shindig template
>
>
> This addresses bug shindig-1737.
> https://issues.apache.org/jira/browse/shindig-1737
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/templates/VarTag.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java 1366998
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/VarTagHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/VarTagHandlerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5973/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Bi
>
>
Re: Review Request: Adding support for
Posted by Erik Bi <bi...@cn.ibm.com>.
> On Aug. 13, 2012, 12:58 p.m., Dan Dumont wrote:
> > Erik. Could you please attach the patch to the JIRA and grant the Apache Foundation License to use it?
Just finish that. thx, Dan.
- Erik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5973/#review10202
-----------------------------------------------------------
On Aug. 8, 2012, 2:08 a.m., Erik Bi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5973/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2012, 2:08 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
>
>
> Description
> -------
>
> According to the spec, you can define a in-line variable via <os:Var>
>
> http://opensocial-resources.googlecode.com/svn/spec/2.0.1/OpenSocial-Templating.xml#rfc.section.8.2
>
> Seems this feature is not implemented in Shindig Java version right now (seen from the code, it's implemented in PHP version.
>
> This patch is to add os:Var support for shindig template
>
>
> This addresses bug shindig-1737.
> https://issues.apache.org/jira/browse/shindig-1737
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/templates/VarTag.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java 1366998
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/VarTagHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/VarTagHandlerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5973/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Bi
>
>
Re: Review Request: Adding support for
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5973/#review10202
-----------------------------------------------------------
Erik. Could you please attach the patch to the JIRA and grant the Apache Foundation License to use it?
- Dan Dumont
On Aug. 8, 2012, 2:08 a.m., Erik Bi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5973/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2012, 2:08 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
>
>
> Description
> -------
>
> According to the spec, you can define a in-line variable via <os:Var>
>
> http://opensocial-resources.googlecode.com/svn/spec/2.0.1/OpenSocial-Templating.xml#rfc.section.8.2
>
> Seems this feature is not implemented in Shindig Java version right now (seen from the code, it's implemented in PHP version.
>
> This patch is to add os:Var support for shindig template
>
>
> This addresses bug shindig-1737.
> https://issues.apache.org/jira/browse/shindig-1737
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/templates/VarTag.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java 1366998
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/VarTagHandler.java PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/VarTagHandlerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5973/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Bi
>
>