[jira] Commented: (HADOOP-4738) saveVersion.sh could write a package-info.java that cannot be compiled when used with git

["Hemanth Yamijala (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-4738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651307#action_12651307 ] 

Hemanth Yamijala commented on HADOOP-4738:
------------------------------------------

An internal git setup we have has the following in the git log:
{code}
$ git log -1 --pretty=oneline
997675219014cc741fc930930333d1414ae9a514 HADOOP-4704. Fix javadoc typos "the the". (szetszwo)
{code}

And build is failing as follows:
{code}
compile-core-classes:
    [javac] Compiling 636 source files to ../hadoop/hadoop/build/classes
    [javac] ../hadoop/build/src/org/apache/hadoop/package-info.java:4: ')' expected
    [javac] @HadoopVersionAnnotation(version="0.20.0-dev", revision="997675219014cc741fc930930333d1414ae9a514 HADOOP-4704. Fix javadoc typos "the the". (szetszwo)",
    [javac]                  ^
    [javac] 1 error

BUILD FAILED
{code}

> saveVersion.sh could write a package-info.java that cannot be compiled when used with git
> -----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-4738
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4738
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: build
>            Reporter: Hemanth Yamijala
>
> When git is being used, the saveVersion.sh script generates a revision based on git log as follows:
> {{revision=`git log -1 --pretty=oneline`}}
> This revision is used to generate the HadoopVersionAnnotation in the package-info file. If the revision string contains quotes this will result in a compile time error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.