You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/12/06 16:06:21 UTC
Review Request 64380: Stout: Used a namespace for UUID.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64380/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jie Yu, and Vinod Kone.
Repository: mesos
Description
-------
To avoid conflicts when introducing a UUID type in Mesos' namespace,
Stout's UUID type is put in the 'id' namespace.
Diffs
-----
3rdparty/stout/include/stout/uuid.hpp 16830840c3528c9c26f57393cfdb73a09558a369
3rdparty/stout/tests/os/filesystem_tests.cpp 57e1dc110c9fcb4960f59f4845b8255f0499df40
3rdparty/stout/tests/os_tests.cpp 93a23a800e5301abdc71c8b61022cc9baabf12c2
3rdparty/stout/tests/protobuf_tests.cpp 543f96cfe8d9b2f857ed31d323596dc25f9f2d44
3rdparty/stout/tests/uuid_tests.cpp 1fbd623cb9902a60eb80e90252ed59a09910ea3e
Diff: https://reviews.apache.org/r/64380/diff/1/
Testing
-------
Tests are run in https://reviews.apache.org/r/64381/
Thanks,
Jan Schlicht
Re: Review Request 64380: Stout: Used a namespace for UUID.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64380/#review193395
-----------------------------------------------------------
Ship it!
Let's move this commit after https://reviews.apache.org/r/64381/ so that as many commits as possible remain buildable.
- Benjamin Bannier
On Dec. 8, 2017, 4:12 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64380/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 4:12 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-8309
> https://issues.apache.org/jira/browse/MESOS-8309
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To avoid conflicts when introducing a UUID type in Mesos' namespace,
> Stout's UUID type is put in the 'id' namespace.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/uuid.hpp 16830840c3528c9c26f57393cfdb73a09558a369
> 3rdparty/stout/tests/os/filesystem_tests.cpp 57e1dc110c9fcb4960f59f4845b8255f0499df40
> 3rdparty/stout/tests/os_tests.cpp 93a23a800e5301abdc71c8b61022cc9baabf12c2
> 3rdparty/stout/tests/protobuf_tests.cpp 543f96cfe8d9b2f857ed31d323596dc25f9f2d44
> 3rdparty/stout/tests/uuid_tests.cpp 1fbd623cb9902a60eb80e90252ed59a09910ea3e
>
>
> Diff: https://reviews.apache.org/r/64380/diff/2/
>
>
> Testing
> -------
>
> Tests are run in https://reviews.apache.org/r/64381/
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 64380: Stout: Used a namespace for UUID.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64380/
-----------------------------------------------------------
(Updated Dec. 12, 2017, 2:56 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Vinod Kone.
Changes
-------
Rebased and changed order of reviews.
Bugs: MESOS-8309
https://issues.apache.org/jira/browse/MESOS-8309
Repository: mesos
Description
-------
To avoid conflicts when introducing a UUID type in Mesos' namespace,
Stout's UUID type is put in the 'id' namespace.
Diffs (updated)
-----
3rdparty/stout/include/stout/uuid.hpp 16830840c3528c9c26f57393cfdb73a09558a369
3rdparty/stout/tests/os/filesystem_tests.cpp 57e1dc110c9fcb4960f59f4845b8255f0499df40
3rdparty/stout/tests/os_tests.cpp 02f2a18b861f185a0dc80c62a69c4b8e15bc1ac2
3rdparty/stout/tests/protobuf_tests.cpp 543f96cfe8d9b2f857ed31d323596dc25f9f2d44
3rdparty/stout/tests/uuid_tests.cpp 1fbd623cb9902a60eb80e90252ed59a09910ea3e
Diff: https://reviews.apache.org/r/64380/diff/3/
Changes: https://reviews.apache.org/r/64380/diff/2-3/
Testing (updated)
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 64380: Stout: Used a namespace for UUID.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64380/
-----------------------------------------------------------
(Updated Dec. 8, 2017, 4:12 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Vinod Kone.
Changes
-------
Rebased on top of #64430.
Bugs: MESOS-8309
https://issues.apache.org/jira/browse/MESOS-8309
Repository: mesos
Description
-------
To avoid conflicts when introducing a UUID type in Mesos' namespace,
Stout's UUID type is put in the 'id' namespace.
Diffs (updated)
-----
3rdparty/stout/include/stout/uuid.hpp 16830840c3528c9c26f57393cfdb73a09558a369
3rdparty/stout/tests/os/filesystem_tests.cpp 57e1dc110c9fcb4960f59f4845b8255f0499df40
3rdparty/stout/tests/os_tests.cpp 93a23a800e5301abdc71c8b61022cc9baabf12c2
3rdparty/stout/tests/protobuf_tests.cpp 543f96cfe8d9b2f857ed31d323596dc25f9f2d44
3rdparty/stout/tests/uuid_tests.cpp 1fbd623cb9902a60eb80e90252ed59a09910ea3e
Diff: https://reviews.apache.org/r/64380/diff/2/
Changes: https://reviews.apache.org/r/64380/diff/1-2/
Testing
-------
Tests are run in https://reviews.apache.org/r/64381/
Thanks,
Jan Schlicht