You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by cm...@collab.net on 2003/04/23 21:25:25 UTC

Re: svn commit: rev 5714 - trunk/subversion/libsvn_client

sussman@tigris.org writes:

> Author: sussman
> Date: Wed Apr 23 15:47:48 2003
> New Revision: 5714

[...]

> @@ -499,20 +575,26 @@
>      {
>        svn_subst_eol_style_t style;
>        const char *eol;
> +      svn_subst_keywords_t *final_kw = apr_pcalloc (pool, sizeof(*final_kw));

Doh!  Heap allocation again.  Just make your structure, and pass its
address to build_final_keyword_struct() and svn_subst_copy_and_translate().

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 5714 - trunk/subversion/libsvn_client

Posted by Branko Čibej <br...@xbc.nu>.
cmpilato@collab.net wrote:

>sussman@tigris.org writes:
>
>  
>
>>Author: sussman
>>Date: Wed Apr 23 15:47:48 2003
>>New Revision: 5714
>>    
>>
>
>[...]
>
>  
>
>>@@ -499,20 +575,26 @@
>>     {
>>       svn_subst_eol_style_t style;
>>       const char *eol;
>>+      svn_subst_keywords_t *final_kw = apr_pcalloc (pool, sizeof(*final_kw));
>>    
>>
>
>Doh!  Heap allocation again.  Just make your structure, and pass its
>address to build_final_keyword_struct() and svn_subst_copy_and_translate().
>  
>

Heh heh. And just the other day, Ben insisted quite vehemently on IRC
that he had *not* done any Java coding. Well, here it is -- Java code
written in C! :-)

-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org